From: Maarten de Vries <maarten@de-vri.es>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] Allow changing `creator_net` after interface creation.
Date: Mon, 4 Feb 2019 01:09:45 +0100 [thread overview]
Message-ID: <CAPWpf+wETOdQGZYSLzMy43DQFdqyvXO5N=q2Qttkebm9TEExsQ@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9o3=5VUp3qXVKtoaAi+dE+5eNA6M9LVJbbs6LUZpDFbVw@mail.gmail.com>
On Mon, 4 Feb 2019 at 00:57, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Hey Maarten,
>
> Thanks for the patch. It turns out that in the git repo, the
> jo/transit-namespace branch from Julian (CC'd) already has something
> that seems very familiar with this. Pending upstreaming, we're holding
> off on adding new features, but following that, we'll start to
> evaluate options like this very seriously.
>
> Do you see a difference between what your patchset does and what Julian's does?
>
> Jason
I'm not sure. I will read through Julian's patches tomorrow, but at a
glance it does appear to address the same issue.
I still sent a follow-up to add missing checks for CAP_NET_ADMIN.
Didn't feel right to leave it here without that, even if none of it is
merged in favour of Julian's patches :)
Kind regards,
Maarten de Vries
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
prev parent reply other threads:[~2019-02-04 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 21:31 [PATCH] Allow changing `creator_net` after interface creation Maarten de Vries
2019-02-03 22:04 ` Julian Orth
2019-02-03 22:08 ` Maarten de Vries
2019-02-04 0:05 ` [PATCH] Check CAP_NET_ADMIN in old and new ns before changing network ns Maarten de Vries
2019-02-04 0:13 ` Maarten de Vries
2019-02-03 23:57 ` [PATCH] Allow changing `creator_net` after interface creation Jason A. Donenfeld
2019-02-04 0:09 ` Maarten de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPWpf+wETOdQGZYSLzMy43DQFdqyvXO5N=q2Qttkebm9TEExsQ@mail.gmail.com' \
--to=maarten@de-vri.es \
--cc=Jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).