wireguard.lists.zx2c4.com archive mirror
 help / color / mirror / Atom feed
* [PATCH] sysdep/bsd: propagate OS-level IFF_MULTICAST to internal IF_MULTICAST flag
@ 2021-04-19 22:26 Toke Høiland-Jørgensen
  2021-05-10 18:16 ` Ondrej Zajicek
  0 siblings, 1 reply; 2+ messages in thread
From: Toke Høiland-Jørgensen @ 2021-04-19 22:26 UTC (permalink / raw)
  To: bird-users; +Cc: Toke Høiland-Jørgensen, wireguard, Stefan Haller

The BSD code did not propagate the OS-level IFF_MULTICAST flag to the
Bird-internal IF_MULTICAST flag, which causes problems with Wireguard
interfaces on FreeBSD. The Linux sysdep code does propagate the flag
already, so just copy over the same check and flag update.

Tested-by: Stefan Haller <stefan.haller@stha.de>
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
---
 sysdep/bsd/krt-sock.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sysdep/bsd/krt-sock.c b/sysdep/bsd/krt-sock.c
index c2faa23dd44f..cd89544063c7 100644
--- a/sysdep/bsd/krt-sock.c
+++ b/sysdep/bsd/krt-sock.c
@@ -665,6 +665,9 @@ krt_read_ifinfo(struct ks_msg *msg, int scan)
   else
     f.flags |= IF_MULTIACCESS;      /* NBMA */
 
+  if (fl & IFF_MULTICAST)
+    f.flags |= IF_MULTICAST;
+
   iface = if_update(&f);
 
   if (!scan)
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sysdep/bsd: propagate OS-level IFF_MULTICAST to internal IF_MULTICAST flag
  2021-04-19 22:26 [PATCH] sysdep/bsd: propagate OS-level IFF_MULTICAST to internal IF_MULTICAST flag Toke Høiland-Jørgensen
@ 2021-05-10 18:16 ` Ondrej Zajicek
  0 siblings, 0 replies; 2+ messages in thread
From: Ondrej Zajicek @ 2021-05-10 18:16 UTC (permalink / raw)
  To: Toke Høiland-Jørgensen; +Cc: bird-users, wireguard, Stefan Haller

On Tue, Apr 20, 2021 at 12:26:53AM +0200, Toke Høiland-Jørgensen wrote:
> The BSD code did not propagate the OS-level IFF_MULTICAST flag to the
> Bird-internal IF_MULTICAST flag, which causes problems with Wireguard
> interfaces on FreeBSD. The Linux sysdep code does propagate the flag
> already, so just copy over the same check and flag update.

Thanks, merged.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-10 18:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 22:26 [PATCH] sysdep/bsd: propagate OS-level IFF_MULTICAST to internal IF_MULTICAST flag Toke Høiland-Jørgensen
2021-05-10 18:16 ` Ondrej Zajicek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).