From: Matt Layher <mdlayher@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: wireguardnl: Go package for interacting with WireGuard via generic netlink
Date: Mon, 23 Jul 2018 11:59:12 -0400 [thread overview]
Message-ID: <ba866611-cd70-5183-bcd4-1ea1e7cc36a5@gmail.com> (raw)
In-Reply-To: <4de6eec9-9239-5e4e-60c1-e287b3be336a@gmail.com>
An update for those on the list, I've implemented Jason's requested name
change and the API is now set up to allow seamless kernel and userspace
implementations via https://godoc.org/github.com/mdlayher/wireguardctrl.
I will explicitly encourage callers to use this interface rather than
the "wireguardnl" package, unless we do end up with useful
netlink-specific functionality like the situation I described previously.
I'll keep working on this for now and report back when I have a working
userspace implementation. Should be quite straightforward compared to
dealing with netlink! :)
- Matt
On 07/23/2018 11:29 AM, Matt Layher wrote:
> Understood and renamed to "wireguardctrl" to avoid confusion.
>
> > But more importantly, you shouldn't expose either the netlink or the
> xplatform API distinction to users ever. They should be given one
> interface, not three, and that one interface should be able to select
> the right thing in 100% of cases.
>
> I can't say I agree with this under all circumstances.
>
> While I will encourage the use of the unified interface, I read that
> there could be future work to allow the netlink interface to support
> something like multicast group notifications. Would you plan on
> implementing the same functionality for the userspace interface?
>
> I think there are potential use cases for selecting one or the other,
> but if this ends up being untrue, I can always push these packages
> behind a Go "internal/" directory at a later time to prevent outside
> imports.
>
> - Matt
>
>
> On 07/23/2018 11:12 AM, Jason A. Donenfeld wrote:
>> Hi Matt,
>>
>>> This is super interesting and I actually did not discover it until
>>> after
>>> I pushed the first few commits to my package. I could see it making
>>> sense to refactor my current package layout to something like three
>>> packages:
>>>
>>> - wireguardnl: netlink-based communication
>>> - wireguardcfg: text-based userspace configuration protocol
>>> communication
>>> - wireguard: wrapper for both that detects the module in use and
>>> seamlessly presents a unified interface
>> No, that's really not a good approach at all. First of all, do not
>> take the raw name "wireguard". That's going to cause a lot of
>> confusion. It's really not appropriate.
>>
>> But more importantly, you shouldn't expose either the netlink or the
>> xplatform API distinction to users ever. They should be given one
>> interface, not three, and that one interface should be able to select
>> the right thing in 100% of cases.
>>
>> Jason
>
next prev parent reply other threads:[~2018-07-23 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 19:19 wireguardnl: Go package for interacting with WireGuard via generic netlink Matt Layher
2018-07-23 11:59 ` Jason A. Donenfeld
2018-07-23 13:43 ` Matt Layher
2018-07-23 15:12 ` Jason A. Donenfeld
2018-07-23 15:29 ` Matt Layher
2018-07-23 15:59 ` Matt Layher [this message]
2018-07-23 16:22 ` Jason A. Donenfeld
2018-07-23 16:22 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba866611-cd70-5183-bcd4-1ea1e7cc36a5@gmail.com \
--to=mdlayher@gmail.com \
--cc=Jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).