workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, workflows@vger.kernel.org
Subject: Re: script to check "Fixes:" tags
Date: Fri, 27 Sep 2019 20:03:15 +0200	[thread overview]
Message-ID: <20190927180315.GE1802011@kroah.com> (raw)
In-Reply-To: <CAL_Jsq+emonMWUdz9jxnc3pnvpijK6CMLq-0dOStQWuHiEw3zA@mail.gmail.com>

On Fri, Sep 27, 2019 at 07:01:17AM -0500, Rob Herring wrote:
> I think we're looking at the problem the wrong way around. Stephen
> shouldn't have to be checking this, and neither should maintainers. It
> could be easily automated. We could have a checkpatch bot that runs
> some subset of checkpatch checks we agree are always errors like the
> ones here and replies to patches with the errors.

Sure, it would be nice to have that, but until someone sets that up to
run on all patches sent to mailing lists, we need something locally to
run to catch these things.

Also, many maintainers mess this up, I run these checks on trees I pull
from and I have caught errors that checkpatch wouldn't have caught due
to maintainers forgetting to sign off on things they are committing
somehow.  email tests wouldn't have caught that.

thanks,

greg k-h

  reply	other threads:[~2019-09-27 18:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 19:51 script to check "Fixes:" tags Greg KH
2019-09-27  7:08 ` Krzysztof Kozlowski
2019-09-27  7:49 ` Geert Uytterhoeven
2019-09-27 12:01   ` Rob Herring
2019-09-27 18:03     ` Greg KH [this message]
2019-09-27 18:01   ` Greg KH
2019-09-27 18:06     ` Geert Uytterhoeven
2019-09-27 18:35       ` Greg KH
2019-09-27 19:00         ` Geert Uytterhoeven
2019-09-27 19:46           ` Theodore Y. Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190927180315.GE1802011@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=geert@linux-m68k.org \
    --cc=robh@kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).