From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: David Miller <davem@davemloft.net>,
skhan@linuxfoundation.org, gregkh@linuxfoundation.org,
patchwork@lists.ozlabs.org, workflows@vger.kernel.org
Subject: Re: RFE: use patchwork to submit a patch
Date: Fri, 11 Oct 2019 15:51:46 -0300 [thread overview]
Message-ID: <20191011155146.31105cc1@coco.lan> (raw)
In-Reply-To: <20191011144401.61007c44@gandalf.local.home>
Em Fri, 11 Oct 2019 14:44:01 -0400
Steven Rostedt <rostedt@goodmis.org> escreveu:
> On Fri, 11 Oct 2019 11:32:54 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Steven Rostedt <rostedt@goodmis.org>
> > Date: Fri, 11 Oct 2019 14:01:08 -0400
> >
> > > Thus, if we want people to send us their fixes, we better keep just
> > > an email with a patch the lowest bar for entry.
> >
> > I argue that for people coming into the software engineering world
> > today, a PR is the lowest bar for entry. And email is the exact
> > opposite, _especially_ our way of doing email.
> >
> > Because it IS NOT just an email with a patch.
>
> That is if the maintainer wants to be anal about the submission. I've
> taken patches where I only asked the person to give me a signed off by.
> I also ask:
>
> "Hi, do you intend on being a contributor, or do you only want to get
> this fix upstream? If the latter, I will handle the change log and
> other formatting for you, all I need is the signed-off-by. Otherwise, I
> will help you submit a proper patch."
>
> Again, this is for one offs, where someone found something like an off
> by one error or other trivial bug to fix. I just want the fix in, but
> will let the submitter decide how strict I will be to get it in. I've
> had people say "I don't care, just get it fixed", and I do the
> formatting and all the grudge work, but still give the submitter the
> credit.
>
> Not to mention, there's several times I get a patch where the solution
> is totally wrong, and I need to make the fix anyway. A simple
> Reported-by is what the submitter gets. Also, perfectly done by email.
>
About the same here: if needed, I change patch descriptions, and
for trivial patches submitted by newbies, I even correct bad whitespacing,
if needed.
All it takes for a patch to be handled is to send it in a way that
patchwork will recognize as a patch - e. g. it should carry a properly
formatted diff.
> >
> > You are not helping casual contributors with this "simple" email based
> > submission method. It is understood and easy us, but nobody else.
>
> I'm not saying that email is the only way, this entire thread is about
> getting another tool to help. But I will scream very loudly if we
> eliminate email totally.
Yes, e-mail should stay.
Thanks,
Mauro
next prev parent reply other threads:[~2019-10-11 18:51 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 14:41 RFE: use patchwork to submit a patch Konstantin Ryabitsev
2019-10-10 18:07 ` Mauro Carvalho Chehab
2019-10-10 19:42 ` Steven Rostedt
2019-10-10 19:53 ` Konstantin Ryabitsev
2019-10-10 20:05 ` Eric Wong
2019-10-10 20:21 ` Jonathan Nieder
2019-10-10 20:36 ` Eric Wong
2019-10-11 18:05 ` Mauro Carvalho Chehab
2019-10-10 20:20 ` Jonathan Nieder
2019-10-10 21:38 ` Daniel Axtens
2019-10-10 22:05 ` Konstantin Ryabitsev
2019-10-11 8:57 ` Greg KH
2019-10-11 17:20 ` Shuah Khan
2019-10-11 17:37 ` Mauro Carvalho Chehab
2019-10-11 18:01 ` Steven Rostedt
2019-10-11 18:32 ` David Miller
2019-10-11 18:44 ` Steven Rostedt
2019-10-11 18:51 ` Mauro Carvalho Chehab [this message]
2019-10-11 18:59 ` Mauro Carvalho Chehab
2019-10-11 19:02 ` Drew DeVault
2019-10-11 19:11 ` David Miller
2019-10-11 21:19 ` Stephen Hemminger
2019-10-11 21:47 ` Steven Rostedt
2019-10-11 22:54 ` Dave Airlie
2019-10-11 23:00 ` Steven Rostedt
2019-10-12 0:08 ` Stephen Hemminger
2019-10-12 0:14 ` Steven Rostedt
2019-10-13 23:38 ` Daniel Axtens
2019-10-14 10:42 ` Toke Høiland-Jørgensen
2019-10-14 12:26 ` Theodore Y. Ts'o
2019-10-14 13:18 ` Toke Høiland-Jørgensen
2019-10-14 13:41 ` Mauro Carvalho Chehab
2019-10-14 13:53 ` Theodore Y. Ts'o
2019-10-14 14:28 ` Mauro Carvalho Chehab
2019-10-14 15:25 ` Konstantin Ryabitsev
2019-10-14 12:27 ` Daniel Axtens
2019-10-14 13:19 ` Steven Rostedt
2019-10-14 14:58 ` Dmitry Vyukov
2019-10-14 15:12 ` Laurent Pinchart
2019-10-15 4:49 ` Dmitry Vyukov
2019-10-15 16:30 ` Laurent Pinchart
2019-10-14 15:17 ` Greg KH
2019-10-14 15:27 ` Laurent Pinchart
2019-10-15 4:41 ` Dmitry Vyukov
2019-10-15 16:07 ` Greg KH
2019-10-14 20:56 ` Theodore Y. Ts'o
2019-10-15 4:39 ` Dmitry Vyukov
2019-10-15 12:37 ` Steven Rostedt
2019-10-15 13:35 ` Theodore Y. Ts'o
2019-10-15 14:05 ` Steven Rostedt
2019-10-15 15:21 ` Konstantin Ryabitsev
2019-10-15 16:37 ` Laurent Pinchart
2019-10-15 16:47 ` Steven Rostedt
2019-10-21 15:39 ` Laurent Pinchart
2019-10-24 13:15 ` Steven Rostedt
2019-10-24 13:33 ` Dmitry Vyukov
2019-10-24 13:58 ` Steven Rostedt
2019-10-24 14:12 ` Dmitry Vyukov
2019-10-15 8:57 ` Eric Wong
2019-10-15 9:11 ` Dmitry Vyukov
2019-10-15 16:24 ` Laurent Pinchart
2019-10-15 16:27 ` Laurent Pinchart
2019-10-21 11:16 ` Dmitry Vyukov
2019-11-08 9:44 ` Dmitry Vyukov
2019-11-08 14:02 ` Theodore Y. Ts'o
2019-11-08 14:11 ` Dmitry Vyukov
2019-11-08 14:12 ` Dmitry Vyukov
2019-11-08 14:17 ` Konstantin Ryabitsev
2019-11-08 14:25 ` Dmitry Vyukov
2019-11-09 4:31 ` Theodore Y. Ts'o
2019-11-11 9:35 ` Dmitry Vyukov
2019-11-11 12:08 ` Mark Brown
2019-11-11 16:17 ` Theodore Y. Ts'o
2019-11-11 20:38 ` Konstantin Ryabitsev
2019-11-08 14:17 ` Laurent Pinchart
2019-10-11 20:02 ` Konstantin Ryabitsev
2019-10-11 21:23 ` Eric Wong
2019-10-11 21:35 ` Konstantin Ryabitsev
2019-10-12 7:19 ` Greg KH
2019-10-14 11:31 ` Mark Brown
2019-10-15 16:11 ` Konstantin Ryabitsev
2019-10-13 23:39 ` Eric Wong
2019-10-14 7:30 ` Geert Uytterhoeven
2019-10-14 22:18 ` Eric Wong
2019-10-15 15:34 ` Konstantin Ryabitsev
2019-10-14 15:33 ` Laurent Pinchart
2019-10-15 15:40 ` Konstantin Ryabitsev
2019-10-15 16:32 ` Laurent Pinchart
2019-10-15 16:34 ` Drew DeVault
2019-10-15 16:44 ` Laurent Pinchart
2019-10-15 17:07 ` Drew DeVault
2019-10-15 17:24 ` Konstantin Ryabitsev
2019-10-11 22:57 ` Dave Airlie
2019-10-12 7:31 ` Greg KH
2019-10-12 13:16 ` Stephen Finucane
2019-10-12 16:13 ` Stephen Finucane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011155146.31105cc1@coco.lan \
--to=mchehab@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=patchwork@lists.ozlabs.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).