From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=3.0 tests=DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C34CA9EA1 for ; Fri, 18 Oct 2019 06:02:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D820E21D80 for ; Fri, 18 Oct 2019 06:02:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389117AbfJRGCi (ORCPT ); Fri, 18 Oct 2019 02:02:38 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:53884 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732713AbfJRGCh (ORCPT ); Fri, 18 Oct 2019 02:02:37 -0400 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C7E851F4C0; Fri, 18 Oct 2019 02:22:53 +0000 (UTC) Date: Fri, 18 Oct 2019 02:22:53 +0000 From: Eric Wong To: Vegard Nossum Cc: workflows@vger.kernel.org, git@vger.kernel.org, linux-kernel@vger.kernel.org, Konstantin Ryabitsev Subject: Re: email as a bona fide git transport Message-ID: <20191018022253.GA29290@dcvr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: workflows-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: workflows@vger.kernel.org Vegard Nossum wrote: > Disadvantages: > > - requires patching git The bigger disadvantage is this won't work with a historical patch series (and some folks stay on ancient git). But maybe that window for that is only a few years... The toughest part right now for public-inbox is trying to make sense of --range-diff (supporting --interdiff would be easy, I think...). Also, we've only had --range-diff for a year or so. Your proposal would make things 100% easier for public-inbox to deal with future --range-diff uses, however :) > - requires a bot to continuously create branches for patchsets sent to > mailing lists Not necessarily, being able to search on commit OIDs would be pretty handy itself for dealing with --range-diff output in public-inbox, so there's no real need to actually make the branch in git. I also have a parallel solution in the works to make --range-diff output more amenable for search engines like public-inbox by adding blob OIDs to its output: https://public-inbox.org/git/20191017121045.GA15364@dcvr/ I shall call myself an "SEO expert" from now on :> > Thoughts? Pretty much the same concerns others brought up around exactness and working on top of cherry-picks. > PS: Eric Wong described something that comes quite close to this idea, but > AFAICT without actually recreating commits exactly. I've included the link > for completeness. [4] > [4]: https://lore.kernel.org/workflows/20191008003931.y4rc2dp64gbhv5ju@dcvr/ My plan is to work on interdiff support in the next week or so once bugs are fixed and public-inbox v1.2 is out the door. Not sure about range-diff and reverse-mapping blobs -> trees -> commits, but searching on "git patch-id --stable" output is also on the table. PS: Attached patches: I have nothing against using MIME for those, (not speaking for anybody else). public-inbox needs to handle those better w.r.t search indexing linkification. And then I found some bugs for --reindex corner cases which I'm still working on :x