From: Greg KH <gregkh@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: workflows@vger.kernel.org
Subject: Re: patch attachments still unwelcome?
Date: Fri, 1 Nov 2019 10:04:56 +0100 [thread overview]
Message-ID: <20191101090456.GD2671695@kroah.com> (raw)
In-Reply-To: <20191101022746.GA25491@dcvr>
On Fri, Nov 01, 2019 at 02:27:46AM +0000, Eric Wong wrote:
> The BDFL sets an example by attaching patches:
>
> https://lore.kernel.org/lkml/?q=f%3Atorvalds+n%3Apatch
>
> So the documentation in the kernel advising against sending
> patch attachments seems hypocritical. Changing the kernel docs
> allow patch attachments could be a good start to making life
> easier for contributors without SMTP or IMAP access.
It's not hypocritical, as lots of email clients still get this wrong and
make responding to attachments almost impossible. Many do get it right,
but trying to document the differences here is quite difficult (I tried
once, gave up as it was a mess).
> Are many MUAs still incapable of handling them?
> mutt shows text patches inline, at least.
For most MUAs that send them, yes, but not for all. I know of at least
2 that send text attachments in formats that mutt will not show it
inline, nor allow responding to them properly. MacOS Mail is one easy
example to point to as getting this totally wrong.
So, if you know what you are doing, yes, this is fine, but it's still a
good idea to say "please do not do this" to make it easier for people
just starting out.
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-01 9:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 2:27 patch attachments still unwelcome? Eric Wong
2019-11-01 9:04 ` Greg KH [this message]
2019-11-04 13:13 ` Theodore Y. Ts'o
2019-11-04 13:23 ` Dmitry Vyukov
2019-11-04 14:49 ` Jani Nikula
2019-11-04 17:40 ` Geert Uytterhoeven
2019-11-05 10:46 ` Geert Uytterhoeven
2019-11-04 13:42 ` Greg KH
2019-11-04 13:42 ` Drew DeVault
2019-11-01 13:00 ` Konstantin Ryabitsev
2019-11-04 11:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101090456.GD2671695@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=e@80x24.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).