From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: workflows@vger.kernel.org
Subject: RFC: using supersedes: trailer to indicate patch/series revision flow
Date: Thu, 7 Nov 2019 15:43:49 -0500 [thread overview]
Message-ID: <20191107204349.hqpefgp7cowj6hof@chatter.i7.local> (raw)
Hi, all:
The only mechanism we currently have for patch/series versioning is
subject suffixes. I think it would be useful to have a way to more
explicitly mark that a series obsoletes a previous version, and I
propose this is done with a `supersedes:` trailer at the end of the
cover letter or in the first patch of the series:
E.g.:
Initial patch:
---8<---
From: Dev Eloper <dev.eloper@example.com>
Message-Id: <1572991351-86061-1-git-send-email-dev.eloper@example.com>
Subject: [PATCH] Change foo
Foo is no good. Use Bar.
Signed-off-by: Dev Eloper <dev.eloper@example.com>
---
foo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/foo b/foo
...
base-commit: 23fdb198ae81f47a574296dab5167c5e136a02ba
--
2.24.0
---8<---
Follow-up patch:
---8<---
From: Dev Eloper <dev.eloper@example.com>
Message-Id: <1572991352-86062-2-git-send-email-dev.eloper@example.com>
Subject: [PATCH,v2] Change foo
Foo is no good. Use Bar. Also use baz.
Signed-off-by: Dev Eloper <dev.eloper@example.com>
---
foo | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/foo b/foo
...
supersedes: <1572991351-86061-1-git-send-email-dev.eloper@example.com>
base-commit: 23fdb198ae81f47a574296dab5167c5e136a02ba
--
2.24.0
---8<---
Questions:
1. Should this be exposed via git-format-patch flags, or just used by
specialized tooling?
2. Should supersedes: link to the previous version of the patch, or the
first ever version of the patch? I am leaning towards the latter,
even though in this case the message-id largely becomes identical in
usage to Gerrit's Change-Id.
3. Should the supersedes trailer have:
a. message-id without brackets
b. message-id with brackets
c. https://lore.kernel.org/r/message-id
My preference is b, to match with The Message-Id header usage.
-K
next reply other threads:[~2019-11-07 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 20:43 Konstantin Ryabitsev [this message]
2019-11-07 23:45 ` RFC: using supersedes: trailer to indicate patch/series revision flow Rafael J. Wysocki
2019-11-08 8:30 ` Han-Wen Nienhuys
2019-11-08 9:59 ` Geert Uytterhoeven
2019-11-08 10:48 ` Laurent Pinchart
2019-11-08 11:00 ` Rafael J. Wysocki
2019-11-08 0:09 ` Andrew Donnellan
2019-11-08 9:19 ` Vegard Nossum
2019-11-08 9:46 ` Geert Uytterhoeven
2019-11-14 6:29 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107204349.hqpefgp7cowj6hof@chatter.i7.local \
--to=konstantin@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).