From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC36C433F5 for ; Mon, 22 Nov 2021 20:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240446AbhKVU1g (ORCPT ); Mon, 22 Nov 2021 15:27:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:40146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233434AbhKVU1f (ORCPT ); Mon, 22 Nov 2021 15:27:35 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45A7E60FD7; Mon, 22 Nov 2021 20:24:28 +0000 (UTC) Date: Mon, 22 Nov 2021 15:24:26 -0500 From: Steven Rostedt To: Thorsten Leemhuis Cc: workflows@vger.kernel.org, Linux Kernel Mailing List , Konstantin Ryabitsev , Jonathan Corbet Subject: Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:' Message-ID: <20211122152426.7c2b3ab4@gandalf.local.home> In-Reply-To: References: <6b760115ecdd3687d4b82680b284f55a04f3ad90.1637566224.git.linux@leemhuis.info> <20211122112916.498810bb@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: workflows@vger.kernel.org On Mon, 22 Nov 2021 19:50:35 +0100 Thorsten Leemhuis wrote: > > That said, I would like a way to have versions show a link to the last > > version that was reviewed. > > > > v1: has no tags > > > > v2: has a Reviewed: tag to v1. > > > > v3: has a Reviewed: tag to v2 > > > > [...] > > > > Then the final commit could have a "Link" or "Reviewed" tag to v3, even > > though there may not be any reviews to v3, but v3 has the link to v2, and > > v2 has the link to v1, etc. > > Is that really worth it? Isn't it sufficient if the commit links to the > last public review posting, as that already should link to all earlier > review postings. Sure, not everybody is doing this right now, but maybe > just educating people to do so is better than creating something new. Isn't "as that already should link to all earlier review postings" what I'm suggesting above? I haven't seen many people do that yet. -- Steve