* [PATCH net v3] docs: netdev: document patchwork patch states
@ 2023-09-01 1:41 Jakub Kicinski
2023-09-01 8:40 ` Sabrina Dubroca
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-09-01 1:41 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, Jakub Kicinski, corbet, workflows,
linux-doc, rdunlap, laurent.pinchart
The patchwork states are largely self-explanatory but small
ambiguities may still come up. Document how we interpret
the states in networking.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v3:
- clarify that patches once set to Awaiting Upstream will stay there
v2: https://lore.kernel.org/all/20230830220659.170911-1-kuba@kernel.org/
- add a sentence about New vs Under Review
- s/maintainer/export/ for Needs ACK
- fix indent
v1: https://lore.kernel.org/all/20230828184447.2142383-1-kuba@kernel.org/
CC: corbet@lwn.net
CC: workflows@vger.kernel.org
CC: linux-doc@vger.kernel.org
CC: rdunlap@infradead.org
CC: laurent.pinchart@ideasonboard.com
---
Documentation/process/maintainer-netdev.rst | 29 ++++++++++++++++++++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
index c1c732e9748b..b2c082e64c95 100644
--- a/Documentation/process/maintainer-netdev.rst
+++ b/Documentation/process/maintainer-netdev.rst
@@ -120,7 +120,34 @@ Status of a patch can be checked by looking at the main patchwork
https://patchwork.kernel.org/project/netdevbpf/list/
The "State" field will tell you exactly where things are at with your
-patch. Patches are indexed by the ``Message-ID`` header of the emails
+patch:
+
+================== =============================================================
+Patch state Description
+================== =============================================================
+New, Under review pending review, patch is in the maintainer’s queue for
+ review; the two states are used interchangeably (depending on
+ the exact co-maintainer handling patchwork at the time)
+Accepted patch was applied to the appropriate networking tree, this is
+ usually set automatically by the pw-bot
+Needs ACK waiting for an ack from an area expert or testing
+Changes requested patch has not passed the review, new revision is expected
+ with appropriate code and commit message changes
+Rejected patch has been rejected and new revision is not expected
+Not applicable patch is expected to be applied outside of the networking
+ subsystem
+Awaiting upstream patch should be reviewed and handled by appropriate
+ sub-maintainer, who will send it on to the networking trees
+Deferred patch needs to be reposted later, usually due to dependency
+ or because it was posted for a closed tree
+Superseded new version of the patch was posted, usually set by the
+ pw-bot
+RFC not to be applied, usually not in maintainer’s review queue,
+ pw-bot can automatically set patches to this state based
+ on subject tags
+================== =============================================================
+
+Patches are indexed by the ``Message-ID`` header of the emails
which carried them so if you have trouble finding your patch append
the value of ``Message-ID`` to the URL above.
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v3] docs: netdev: document patchwork patch states
2023-09-01 1:41 [PATCH net v3] docs: netdev: document patchwork patch states Jakub Kicinski
@ 2023-09-01 8:40 ` Sabrina Dubroca
2023-09-01 14:22 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Sabrina Dubroca @ 2023-09-01 8:40 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, corbet, workflows, linux-doc,
rdunlap, laurent.pinchart
2023-08-31, 18:41:29 -0700, Jakub Kicinski wrote:
> The patchwork states are largely self-explanatory but small
> ambiguities may still come up. Document how we interpret
> the states in networking.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v3:
> - clarify that patches once set to Awaiting Upstream will stay there
mhmm, the patch looks identical to v2. Did you post the wrong version?
--
Sabrina
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v3] docs: netdev: document patchwork patch states
2023-09-01 8:40 ` Sabrina Dubroca
@ 2023-09-01 14:22 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-09-01 14:22 UTC (permalink / raw)
To: Sabrina Dubroca
Cc: davem, netdev, edumazet, pabeni, corbet, workflows, linux-doc,
rdunlap, laurent.pinchart
On Fri, 1 Sep 2023 10:40:21 +0200 Sabrina Dubroca wrote:
> > v3:
> > - clarify that patches once set to Awaiting Upstream will stay there
>
> mhmm, the patch looks identical to v2. Did you post the wrong version?
oops, forgot to commit, thanks for catching!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-01 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-01 1:41 [PATCH net v3] docs: netdev: document patchwork patch states Jakub Kicinski
2023-09-01 8:40 ` Sabrina Dubroca
2023-09-01 14:22 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).