* [PATCH net v4] docs: netdev: document patchwork patch states
@ 2023-09-01 14:24 Jakub Kicinski
2023-09-04 8:48 ` patchwork-bot+netdevbpf
2023-09-04 10:50 ` Martin Habets
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-09-01 14:24 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, Jakub Kicinski, corbet, workflows,
linux-doc, rdunlap, laurent.pinchart, sd
The patchwork states are largely self-explanatory but small
ambiguities may still come up. Document how we interpret
the states in networking.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v4:
- clarify that patches once set to Awaiting Upstream will stay there
v3: no change
v2: https://lore.kernel.org/all/20230830220659.170911-1-kuba@kernel.org/
- add a sentence about New vs Under Review
- s/maintainer/export/ for Needs ACK
- fix indent
v1: https://lore.kernel.org/all/20230828184447.2142383-1-kuba@kernel.org/
CC: corbet@lwn.net
CC: workflows@vger.kernel.org
CC: linux-doc@vger.kernel.org
CC: rdunlap@infradead.org
CC: laurent.pinchart@ideasonboard.com
CC: sd@queasysnail.net
---
Documentation/process/maintainer-netdev.rst | 32 ++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
index c1c732e9748b..db1b81cfba9b 100644
--- a/Documentation/process/maintainer-netdev.rst
+++ b/Documentation/process/maintainer-netdev.rst
@@ -120,7 +120,37 @@ Status of a patch can be checked by looking at the main patchwork
https://patchwork.kernel.org/project/netdevbpf/list/
The "State" field will tell you exactly where things are at with your
-patch. Patches are indexed by the ``Message-ID`` header of the emails
+patch:
+
+================== =============================================================
+Patch state Description
+================== =============================================================
+New, Under review pending review, patch is in the maintainer’s queue for
+ review; the two states are used interchangeably (depending on
+ the exact co-maintainer handling patchwork at the time)
+Accepted patch was applied to the appropriate networking tree, this is
+ usually set automatically by the pw-bot
+Needs ACK waiting for an ack from an area expert or testing
+Changes requested patch has not passed the review, new revision is expected
+ with appropriate code and commit message changes
+Rejected patch has been rejected and new revision is not expected
+Not applicable patch is expected to be applied outside of the networking
+ subsystem
+Awaiting upstream patch should be reviewed and handled by appropriate
+ sub-maintainer, who will send it on to the networking trees;
+ patches set to ``Awaiting upstream`` in netdev's patchwork
+ will usually remain in this state, whether the sub-maintainer
+ requested changes, accepted or rejected the patch
+Deferred patch needs to be reposted later, usually due to dependency
+ or because it was posted for a closed tree
+Superseded new version of the patch was posted, usually set by the
+ pw-bot
+RFC not to be applied, usually not in maintainer’s review queue,
+ pw-bot can automatically set patches to this state based
+ on subject tags
+================== =============================================================
+
+Patches are indexed by the ``Message-ID`` header of the emails
which carried them so if you have trouble finding your patch append
the value of ``Message-ID`` to the URL above.
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v4] docs: netdev: document patchwork patch states
2023-09-01 14:24 [PATCH net v4] docs: netdev: document patchwork patch states Jakub Kicinski
@ 2023-09-04 8:48 ` patchwork-bot+netdevbpf
2023-09-04 10:50 ` Martin Habets
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-04 8:48 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, corbet, workflows, linux-doc,
rdunlap, laurent.pinchart, sd
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 1 Sep 2023 07:24:05 -0700 you wrote:
> The patchwork states are largely self-explanatory but small
> ambiguities may still come up. Document how we interpret
> the states in networking.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v4:
> - clarify that patches once set to Awaiting Upstream will stay there
> v3: no change
> v2: https://lore.kernel.org/all/20230830220659.170911-1-kuba@kernel.org/
> - add a sentence about New vs Under Review
> - s/maintainer/export/ for Needs ACK
> - fix indent
> v1: https://lore.kernel.org/all/20230828184447.2142383-1-kuba@kernel.org/
>
> [...]
Here is the summary with links:
- [net,v4] docs: netdev: document patchwork patch states
https://git.kernel.org/netdev/net/c/ee8ab74aa0c2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v4] docs: netdev: document patchwork patch states
2023-09-01 14:24 [PATCH net v4] docs: netdev: document patchwork patch states Jakub Kicinski
2023-09-04 8:48 ` patchwork-bot+netdevbpf
@ 2023-09-04 10:50 ` Martin Habets
1 sibling, 0 replies; 3+ messages in thread
From: Martin Habets @ 2023-09-04 10:50 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, corbet, workflows, linux-doc,
rdunlap, laurent.pinchart, sd
On Fri, Sep 01, 2023 at 07:24:05AM -0700, Jakub Kicinski wrote:
> The patchwork states are largely self-explanatory but small
> ambiguities may still come up. Document how we interpret
> the states in networking.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com>
> ---
> v4:
> - clarify that patches once set to Awaiting Upstream will stay there
> v3: no change
> v2: https://lore.kernel.org/all/20230830220659.170911-1-kuba@kernel.org/
> - add a sentence about New vs Under Review
> - s/maintainer/export/ for Needs ACK
> - fix indent
> v1: https://lore.kernel.org/all/20230828184447.2142383-1-kuba@kernel.org/
>
> CC: corbet@lwn.net
> CC: workflows@vger.kernel.org
> CC: linux-doc@vger.kernel.org
>
> CC: rdunlap@infradead.org
> CC: laurent.pinchart@ideasonboard.com
> CC: sd@queasysnail.net
> ---
> Documentation/process/maintainer-netdev.rst | 32 ++++++++++++++++++++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index c1c732e9748b..db1b81cfba9b 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -120,7 +120,37 @@ Status of a patch can be checked by looking at the main patchwork
> https://patchwork.kernel.org/project/netdevbpf/list/
>
> The "State" field will tell you exactly where things are at with your
> -patch. Patches are indexed by the ``Message-ID`` header of the emails
> +patch:
> +
> +================== =============================================================
> +Patch state Description
> +================== =============================================================
> +New, Under review pending review, patch is in the maintainer’s queue for
> + review; the two states are used interchangeably (depending on
> + the exact co-maintainer handling patchwork at the time)
> +Accepted patch was applied to the appropriate networking tree, this is
> + usually set automatically by the pw-bot
> +Needs ACK waiting for an ack from an area expert or testing
> +Changes requested patch has not passed the review, new revision is expected
> + with appropriate code and commit message changes
> +Rejected patch has been rejected and new revision is not expected
> +Not applicable patch is expected to be applied outside of the networking
> + subsystem
> +Awaiting upstream patch should be reviewed and handled by appropriate
> + sub-maintainer, who will send it on to the networking trees;
> + patches set to ``Awaiting upstream`` in netdev's patchwork
> + will usually remain in this state, whether the sub-maintainer
> + requested changes, accepted or rejected the patch
> +Deferred patch needs to be reposted later, usually due to dependency
> + or because it was posted for a closed tree
> +Superseded new version of the patch was posted, usually set by the
> + pw-bot
> +RFC not to be applied, usually not in maintainer’s review queue,
> + pw-bot can automatically set patches to this state based
> + on subject tags
> +================== =============================================================
> +
> +Patches are indexed by the ``Message-ID`` header of the emails
> which carried them so if you have trouble finding your patch append
> the value of ``Message-ID`` to the URL above.
>
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-04 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-01 14:24 [PATCH net v4] docs: netdev: document patchwork patch states Jakub Kicinski
2023-09-04 8:48 ` patchwork-bot+netdevbpf
2023-09-04 10:50 ` Martin Habets
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).