From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817E5CA9EA0 for ; Fri, 18 Oct 2019 06:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33CE520820 for ; Fri, 18 Oct 2019 06:34:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gandi.net header.i=@gandi.net header.b="SPPiFN+n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504411AbfJRGeU (ORCPT ); Fri, 18 Oct 2019 02:34:20 -0400 Received: from mail12.gandi.net ([217.70.182.73]:41999 "EHLO gandi.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2392981AbfJRGeT (ORCPT ); Fri, 18 Oct 2019 02:34:19 -0400 Received: from diconico07.dev (unknown [IPv6:2001:4b98:beef:a:e921:9c91:35ed:759a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by gandi.net (Postfix) with ESMTPSA id A11781602FD; Fri, 18 Oct 2019 06:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gandi.net; s=20190808; t=1571380457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jpi61/2s16j3fMtRfMj2xF4NuVyqdh4656NY34j9qBw=; b=SPPiFN+nP1KBYsIYmk+vIOht95Cx/oNJm0rrk9zrtSCBbrDaeHT9N6rOdh/dcMYOFYIC9e GMqfRhIz+DG2+i/FP0IUHyBNeWxWHeH2GAt7iSIiIsY10NtgT6ZbbW1NT4VWG1V71ix3x5 fFGMVgRdw9v50NGTsTNv6pXL+AddYF2oxvRz5ZX6g3wdFSbZNI/+sudoqkIXG4myGeeVY+ ZxXIvpAAHW4hMdiB+fqIU8DkUMGwbd7km1DW81Ke9JidW9LieCaIPAgy3hxTm+IbPQY8tk HwqjI93URS2jntDPKiBZukWPnJs68Aaxb6tw2Tpsshg4Z/+Tc16flbeB9m0zMQ== Subject: Re: email as a bona fide git transport To: Willy Tarreau , Greg KH , Santiago Torres Arias , Vegard Nossum , workflows@vger.kernel.org, Git Mailing List , LKML , Eric Wong References: <20191016111009.GE13154@1wt.eu> <20191016144517.giwip4yuaxtcd64g@LykOS.localdomain> <20191017204343.GA1132188@kroah.com> <20191017204532.GA6446@chatter.i7.local> <20191018013029.GA1167832@kroah.com> <20191018015447.GB6446@chatter.i7.local> <20191018025215.GA15777@1wt.eu> From: Nicolas Belouin Message-ID: <4ea21178-0cac-e958-7c69-ad5b4a74e6b5@gandi.net> Date: Fri, 18 Oct 2019 08:34:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191018025215.GA15777@1wt.eu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: workflows-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: workflows@vger.kernel.org On 10/18/19 4:52 AM, Willy Tarreau wrote: > On Thu, Oct 17, 2019 at 09:54:47PM -0400, Konstantin Ryabitsev wrote: >> On Thu, Oct 17, 2019 at 06:30:29PM -0700, Greg KH wrote: >>>> It could only possibly work if nobody ever adds their own >>>> "Signed-Off-By" or >>>> any other bylines. I expect this is a deal-breaker for most maintainers. >>> Yeah it is :( >>> >>> But, if we could just have the signature on the code change, not the >>> changelog text, that would help with that issue. >> We totally should, and I even mused on how we would do that here: >> https://public-inbox.org/git/20190910121324.GA6867@pure.paranoia.local/ >> >> However, since git's PGP signatures are made for the content in the actual >> commit record (tree hash, parent, author, commit message, etc), the only way >> we could preserve them between the email and the git tree is if we never >> modify any of that data. The SOB and other trailers would have to only be >> applied to the merge commit, or migrate into commit notes. > There's also the possibility to handle this a bit like we do when adding > comments before the SOB: a PGP signature would apply to the text *before* > it only. We could then have long chains of SOB, PGP, SOB, PGP etc. > > Willy I don't think it can work that easily as the signed content is not just the message. It would need git to support nesting signatures and to allow amending a commit without touching the signature and to allow adding one to cover the new content and to have a way to verify every step. Moreover you won't be able to reparent the commit as a maintainer (wich I think is also a deal-breaker) Nicolas