Workflows Archive on lore.kernel.org
 help / color / Atom feed
From: Dmitry Vyukov <dvyukov@google.com>
To: workflows@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Cc: Han-Wen Nienhuys <hanwen@google.com>,
	Brendan Higgins <brendanhiggins@google.com>,
	Ben Gardon <bgardon@google.com>, Jonathan Nieder <jrn@google.com>,
	Alexei Starovoitov <ast@kernel.org>
Subject: public gerrit instance for kernel
Date: Wed, 26 Feb 2020 09:28:29 +0100
Message-ID: <CACT4Y+Yezqn1JZac9=R1dmgZ4d6N1btAsP6AHON-Cds1knTaiA@mail.gmail.com> (raw)

Hi,

We've setup a public Gerrit instance for use with Linux kernel development:
https://linux.googlesource.com/Documentation/#gerrit-code-reviews-for-the-linux-kernel

After one-time setup changes can be pushed with a single command:
$ git push gerrit-net HEAD:refs/for/master

Gerrit has several (subjective) benefits over email-based reviews:
 - full context (you can expand more context as necessary)
 - diffs between version, e.g. full change is +547 lines:
https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2265/2
but diff between v1 and v2 is just 2 empty lines:
https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2265/1..2
(no need to write that up, trust subjective write ups)
 - colored side-by-side diffs, e.g. here you can easily see that even
that line has changed it's only slash at the end that's added:
https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2103/1/kunit/Makefile#2
 - marking files as "reviewed", always correct base tree/revision, etc

But note there is no "official" story for gerrit in the linux process.
You may use it as you find fit. Some uses that we found useful so far:
 - upload to do self-pre-review
 - review within a team of people who agree to use gerrit
 - include a link to gerrit into the upstream patch email as FYI
(after “---” line)
 - upload somebody else patch just to review with side-by-side diffs
and full context

The branches are mirrored automatically from kernel.org; you can
upload changes for review against those branches, but submission has
to be routed through the traditional process.

If you are brave enough, you may use a gerrit-managed tree as well,
then with ability to merge/edit change on the web, non-losing comment
threads attached to lines of code, change status tracking, etc. But
that will need to be setup separately.

There are some improvements planned like not requiring Change-ID and
proxying comments to/from kernel mailing lists. But that's only in
plans now.

Thanks

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACT4Y+Yezqn1JZac9=R1dmgZ4d6N1btAsP6AHON-Cds1knTaiA@mail.gmail.com' \
    --to=dvyukov@google.com \
    --cc=ast@kernel.org \
    --cc=bgardon@google.com \
    --cc=brendanhiggins@google.com \
    --cc=hanwen@google.com \
    --cc=jrn@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Workflows Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/workflows/0 workflows/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 workflows workflows/ https://lore.kernel.org/workflows \
		workflows@vger.kernel.org
	public-inbox-index workflows

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.workflows


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git