Workflows Archive on lore.kernel.org
 help / color / Atom feed
* Ideas from Jane Street's code review
@ 2019-09-26 15:06 Barret Rhoden
  2019-09-30 10:38 ` Dmitry Vyukov
  0 siblings, 1 reply; 2+ messages in thread
From: Barret Rhoden @ 2019-09-26 15:06 UTC (permalink / raw)
  To: workflows

Hi -

Jane Street did some interesting things with their code review and 
workflow, such as handling diffs-of-diffs and tracking what needs to be 
reviewed.

Their ideas might be orthogonal to the whole "workflow that works for 
email / web / your-tool-here" discussion, but some of the underlying 
principles may inspire a good overall design:

Tech talk:
https://blog.janestreet.com/jane-street-tech-talk-how-jane-street-does-code-review/

Links to their blogs:
https://github.com/janestreet/iron

Barret


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Ideas from Jane Street's code review
  2019-09-26 15:06 Ideas from Jane Street's code review Barret Rhoden
@ 2019-09-30 10:38 ` Dmitry Vyukov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Vyukov @ 2019-09-30 10:38 UTC (permalink / raw)
  To: Barret Rhoden; +Cc: workflows

On Thu, Sep 26, 2019 at 5:06 PM Barret Rhoden <brho@google.com> wrote:
>
> Hi -
>
> Jane Street did some interesting things with their code review and
> workflow, such as handling diffs-of-diffs and tracking what needs to be
> reviewed.
>
> Their ideas might be orthogonal to the whole "workflow that works for
> email / web / your-tool-here" discussion, but some of the underlying
> principles may inspire a good overall design:
>
> Tech talk:
> https://blog.janestreet.com/jane-street-tech-talk-how-jane-street-does-code-review/
>
> Links to their blogs:
> https://github.com/janestreet/iron


Interesting idea of editing, saving and committing comments along with
the code into review branches.
Added it to the list for completeness:
https://github.com/dvyukov/kit/blob/master/doc/references.md#iron
Thanks, Barret.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-26 15:06 Ideas from Jane Street's code review Barret Rhoden
2019-09-30 10:38 ` Dmitry Vyukov

Workflows Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/workflows/0 workflows/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 workflows workflows/ https://lore.kernel.org/workflows \
		workflows@vger.kernel.org workflows@archiver.kernel.org
	public-inbox-index workflows

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.workflows


AGPL code for this site: git clone https://public-inbox.org/ public-inbox