From: Vegard Nossum <vegard.nossum@oracle.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Willy Tarreau <w@1wt.eu>,
Santiago Torres Arias <santiago@nyu.edu>,
workflows@vger.kernel.org, Git Mailing List <git@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Eric Wong <e@80x24.org>
Subject: Re: email as a bona fide git transport
Date: Tue, 22 Oct 2019 18:29:34 +0200 [thread overview]
Message-ID: <eed119a2-1561-131e-9d3d-d4d5aadee825@oracle.com> (raw)
In-Reply-To: <20191022135344.GC23268@mit.edu>
On 10/22/19 3:53 PM, Theodore Y. Ts'o wrote:
> On Tue, Oct 22, 2019 at 02:11:22PM +0200, Vegard Nossum wrote:
>>
>> As I wrote in there, we could already today start using
>>
>> git am --message-id
>>
>> when applying patches and this would provide something that a bot could
>> annotate with git notes pointing to lore/LKML/LWN/whatever. I think that
>> would already be a pretty nice improvement over today's situation.
>>
>> Sadly, since the beginning of 2018, this was only used for a measly
>> ~0.14% of all non-merge commits in the kernel:
>>
>> $ git rev-list --count --no-merges --since='2018-01-01' --grep 'Message-Id:
>> ' linus/master
>> 178
>
> You might also want to count commits which have a link tag with a
> Message-Id:
>
> Link: https://lore.kernel.org/r/c3438dad66a34a7d4e7509a5dd64c2326340a52a.1571647180.git.mbobrowski@mbobrowski.org
>
> That's because some kernel developers have been using a hook script like this:
>
> #!/bin/sh
> # For .git/hooks/applypatch-msg
> #
> # You must have the following in .git/config:
> # [am]
> # messageid = true
>
> . git-sh-setup
> perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Link: https://lore.kernel.org/r/$1|g;' "$1"
> test -x "$GIT_DIR/hooks/commit-msg" &&
> exec "$GIT_DIR/hooks/commit-msg" ${1+"$@"}
> :
>
> .... as we had reached rough consensus that this was the best way to
> incorprate the message id (since it could made to be a clickable link
> in tools like gitk, for example). This rough consensus has only been
> in place since around the time of the Maintainer's Summit in Lisbon,
> so uptake is still probably a bit slow. I'd expect to see a lot more
> of this in the next merge window, though.
Thanks, I was not aware of this!
Seems like something that should go in Documentation/maintainer/,
right?
The figure is much better, 16.7% on all non-merges since 2018-01-01.
This should help and we can maybe already do some interesting things
with git notes and lore/public-inbox.
Vegard
next prev parent reply other threads:[~2019-10-22 16:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 10:22 email as a bona fide git transport Vegard Nossum
2019-10-16 11:10 ` Willy Tarreau
2019-10-16 14:45 ` Santiago Torres Arias
2019-10-17 20:43 ` Greg KH
2019-10-17 20:45 ` Konstantin Ryabitsev
2019-10-18 1:30 ` Greg KH
2019-10-18 1:54 ` Konstantin Ryabitsev
2019-10-18 2:52 ` Willy Tarreau
2019-10-18 6:34 ` Nicolas Belouin
2019-10-18 15:50 ` Santiago Torres Arias
2019-10-20 5:50 ` Laurent Pinchart
2019-10-18 14:27 ` Vegard Nossum
2019-10-18 15:54 ` Santiago Torres Arias
2019-10-18 16:03 ` Konstantin Ryabitsev
2019-10-18 16:11 ` Santiago Torres Arias
2019-10-18 18:00 ` Konstantin Ryabitsev
2019-10-18 16:15 ` Theodore Y. Ts'o
2019-10-18 16:50 ` Vegard Nossum
2019-10-18 19:14 ` Theodore Y. Ts'o
2019-10-20 3:17 ` Willy Tarreau
2019-10-20 6:28 ` Vegard Nossum
2019-10-22 12:11 ` Vegard Nossum
2019-10-22 13:53 ` Theodore Y. Ts'o
2019-10-22 16:29 ` Vegard Nossum [this message]
2019-10-22 19:01 ` Eric Wong
2019-10-16 15:00 ` Pratyush Yadav
2019-10-17 12:23 ` Vegard Nossum
2019-10-17 13:11 ` Theodore Y. Ts'o
2019-10-17 14:01 ` Vegard Nossum
2019-10-17 14:47 ` Theodore Y. Ts'o
2019-10-17 15:11 ` Steven Rostedt
2019-10-16 20:57 ` Jonathan Nieder
2019-10-17 13:08 ` Vegard Nossum
2019-10-17 3:17 ` Junio C Hamano
2019-10-17 13:30 ` Vegard Nossum
2019-10-18 2:22 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eed119a2-1561-131e-9d3d-d4d5aadee825@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santiago@nyu.edu \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).