Re: [PATCH] hwrng: mxc-rnga: Drop usage of platform_driver_probe() - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Olivia Mackall <olivia@selenic.com>,
	 Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, kernel@pengutronix.de,
	 linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] hwrng: mxc-rnga: Drop usage of platform_driver_probe()
Date: Mon, 29 Apr 2024 22:16:34 +0200	[thread overview]
Message-ID: <wu6kc2ctezq476pc3gebgiikml6xvf3ipqawdiiccq4vixdl2r@4qv55vvr4kr5> (raw)
In-Reply-To: <20240324103759.228009-2-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Hello,

On Sun, Mar 24, 2024 at 11:37:59AM +0100, Uwe Kleine-König wrote:
> There are considerations to drop platform_driver_probe() as a concept
> that isn't relevant any more today. It comes with an added complexity
> that makes many users hold it wrong. (E.g. this driver should have mark
> the driver struct with __refdata.)
> 
> Convert the driver to the more usual module_platform_driver().
> 
> This fixes a W=1 build warning:
> 
> 	WARNING: modpost: drivers/char/hw_random/mxc-rnga: section mismatch in reference: mxc_rnga_driver+0x10 (section: .data) -> mxc_rnga_remove (section: .exit.text)
> 
> with CONFIG_HW_RANDOM_MXC_RNGA=m.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Gentle ping?! Who is the one to pick up this patch (or give feedback to
it)?

I want to change modpost to emit this type of warning also for W=0
builds. For that it would be good to have this patch applied first.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]