From: Jeff Moyer <jmoyer@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfsprogs: mkfs: don't default to the physical sector size if it's bigger than XFS_MAX_SECTORSIZE
Date: Tue, 28 Jan 2020 11:54:17 -0500 [thread overview]
Message-ID: <x49zhe7serq.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: 20200128161423.GO3447196@magnolia
"Darrick J. Wong" <darrick.wong@oracle.com> writes:
> Do we need to check that ft->lsectorsize <= XFS_MAX_SECTORSIZE too?
We can. What would be the correct response to such a situation?
> (Not that I really expect disks with 64k LBA units...)
It looks like you can tell loop to do that, but I wasn't able to make
that happen in practice. I'm not quite sure why, though.
-Jeff
next prev parent reply other threads:[~2020-01-28 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 16:07 [PATCH] xfsprogs: mkfs: don't default to the physical sector size if it's bigger than XFS_MAX_SECTORSIZE Jeff Moyer
2020-01-28 16:14 ` Darrick J. Wong
2020-01-28 16:54 ` Jeff Moyer [this message]
2020-01-28 23:53 ` Dave Chinner
2020-02-04 18:38 ` Jeff Moyer
2021-04-16 17:39 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49zhe7serq.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.