From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B98C433DF for ; Tue, 30 Jun 2020 15:17:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4BE82074F for ; Tue, 30 Jun 2020 15:17:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ja3Hoc6g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4BE82074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jqI0Z-0005hW-Ee; Tue, 30 Jun 2020 15:17:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jqI0Y-0005hR-LL for xen-devel@lists.xenproject.org; Tue, 30 Jun 2020 15:17:14 +0000 X-Inumbo-ID: c693eda4-bae4-11ea-b7bb-bc764e2007e4 Received: from mail-wm1-x331.google.com (unknown [2a00:1450:4864:20::331]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c693eda4-bae4-11ea-b7bb-bc764e2007e4; Tue, 30 Jun 2020 15:17:14 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id w3so7522349wmi.4 for ; Tue, 30 Jun 2020 08:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=U6gpWx6s17H1M9VJ6Oh9vPNBpxTYgr9zPk06ZNP9duI=; b=Ja3Hoc6gm808R+iiHXJ+YTAB271DNWOUMLTS3qsKPBA7ZFG3UVpjeCbmkTMVW/MmmS udqS+4mb3AruFaeVOe0C1raIYsMTMceHOAnlWJJuMLTmY87Z0vXABnTM335EqBF9tT1Q NzE0qFz2yvj+xh39kjoODv61pD10rsrqDAxgZABMBIwu8dBOabU7Gs4wxsWLNiIrUwhZ kzFSeIakj5PM4qlq4H8sdRLeOHdcQjgwUdBJ0b0eLdqn6EBP1UuqdP1aHYem9B7FtvCL XNln51//kteHAqh2OuA5CRnQH7n0GV2dcinLuyUabbNegMRIQ/MkZX7rb/m/r21kcm6I NDAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :thread-index:content-language; bh=U6gpWx6s17H1M9VJ6Oh9vPNBpxTYgr9zPk06ZNP9duI=; b=L3ym1ZbwJUMA9jBxNRw2oHcU5O+lY0AUD5Hx/mGMe4PF6dsLa7+EY4vJGqPfp7hR2a g7Jd15oRvl3D/Z+8jx4bwrJnIpG0KOgIbJd42GDcPKIGKdtWZvWlgKTTI6Kmzwr5/I42 LwArqaMw8DhERl9aqkm8caQOTTGMMJCmj7MvfPapX0lw68oYfvSVj9V+Iu5y+QSQ+GCs Xdaikn3FrXZwo/ryH3jbFJS42D3yHs5apBp/44Xl+I5mD4ODq34gnF4trtE5FdTgcYeo CLB34VLiNL/gXwXemuYI2+b7YhE54qeNMGYcjb93NlsiCm3CSCrz1TM4au2zzdrIp5+I iltA== X-Gm-Message-State: AOAM531nBWHS5mYBN/jHpjYfj4wzn6vWaNwJTLOVqbNy8vgBtE3bf4aw 8hzZd0tGvnSN2RxGv/dPmoE= X-Google-Smtp-Source: ABdhPJz5rAGiFZIDrdJqvVJJ5HKWQXmPiwBmtxY124AwSoiwMS1+l2nVEKBvptNnZcYRRS1epYZK1A== X-Received: by 2002:a7b:c348:: with SMTP id l8mr23780539wmj.54.1593530233192; Tue, 30 Jun 2020 08:17:13 -0700 (PDT) Received: from CBGR90WXYV0 (54-240-197-230.amazon.com. [54.240.197.230]) by smtp.gmail.com with ESMTPSA id j41sm4207738wre.12.2020.06.30.08.17.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jun 2020 08:17:12 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Anthony PERARD'" References: <20200624121841.17971-1-paul@xen.org> <20200624121841.17971-3-paul@xen.org> <20200630150849.GA2110@perard.uk.xensource.com> In-Reply-To: <20200630150849.GA2110@perard.uk.xensource.com> Subject: RE: [PATCH 2/2] xen: cleanup unrealized flash devices Date: Tue, 30 Jun 2020 16:17:11 +0100 Message-ID: <000401d64ef1$87c8d8a0$975a89e0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJSqy6H9p+wwq7WTKLIQgTsJ4xkIwGyH0+lAR9Jc9Sn4gFdsA== Content-Language: en-gb X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Eduardo Habkost' , "'Michael S. Tsirkin'" , 'Paul Durrant' , 'Jason Andryuk' , qemu-devel@nongnu.org, 'Paolo Bonzini' , xen-devel@lists.xenproject.org, 'Richard Henderson' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Anthony PERARD > Sent: 30 June 2020 16:09 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; qemu-devel@nongnu.org; Eduardo Habkost ; > Michael S. Tsirkin ; Paul Durrant ; Jason Andryuk > ; Paolo Bonzini ; Richard Henderson > Subject: Re: [PATCH 2/2] xen: cleanup unrealized flash devices > > On Wed, Jun 24, 2020 at 01:18:41PM +0100, Paul Durrant wrote: > > From: Paul Durrant > > > > The generic pc_machine_initfn() calls pc_system_flash_create() which creates > > 'system.flash0' and 'system.flash1' devices. These devices are then realized > > by pc_system_flash_map() which is called from pc_system_firmware_init() which > > itself is called via pc_memory_init(). The latter however is not called when > > xen_enable() is true and hence the following assertion fails: > > > > qemu-system-i386: hw/core/qdev.c:439: qdev_assert_realized_properly: > > Assertion `dev->realized' failed > > > > These flash devices are unneeded when using Xen so this patch avoids the > > assertion by simply removing them using pc_system_flash_cleanup_unused(). > > > > Reported-by: Jason Andryuk > > Fixes: ebc29e1beab0 ("pc: Support firmware configuration with -blockdev") > > Signed-off-by: Paul Durrant > > Tested-by: Jason Andryuk > > Reviewed-by: Anthony PERARD > > I think I would add: > > Fixes: dfe8c79c4468 ("qdev: Assert onboard devices all get realized properly") > > as this is the first commit where the unrealized flash devices are an > issue. OK. Paul > > -- > Anthony PERARD