From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED618C433E0 for ; Fri, 26 Jun 2020 10:41:34 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAD65206B7 for ; Fri, 26 Jun 2020 10:41:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s0XsWscj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAD65206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jolnH-0004Ug-De; Fri, 26 Jun 2020 10:41:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jolnG-0004Ub-Fv for xen-devel@lists.xenproject.org; Fri, 26 Jun 2020 10:41:14 +0000 X-Inumbo-ID: 8e4c8a08-b799-11ea-8496-bc764e2007e4 Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8e4c8a08-b799-11ea-8496-bc764e2007e4; Fri, 26 Jun 2020 10:41:13 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id g18so9052472wrm.2 for ; Fri, 26 Jun 2020 03:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=hrZx328xFMdqRk3GEzuNDkIS4cmTBPvBlwK6wnYbx/Q=; b=s0XsWscjF6IL2OxcvbGnbl2/251Nm2z0aL+0V1SW3ULwaaG9CXWJvOT+xHfdMEV/hw gDOoxyR1hdntTGjzS/OQfeSAwmlGiiblu1jyD9bC6RFrdqR0cXwN93XEUVbnxi8U5Cw/ rz3HP2zP7oWop19eEVSXG+w5eGiNVaSl2I8EWExcOtf7fMEskXSFUHZJy8tCWBP6Vhxd WtBxV+NYMduZ1U4PBI2BxhvsAgk1nrjvcG8Ldt1FkBBT3y27jfP27KqAoRug36YDTAYm o4HF0+J12YSHBnLutEXdMHx6idI4mdwLYqZ88DP4QhjfsUmF5aOGAnKmF63/hmKwNDhn BRCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=hrZx328xFMdqRk3GEzuNDkIS4cmTBPvBlwK6wnYbx/Q=; b=IuWXGP5voM75ZSghwqZMuu7x9wOIL226Ia01Ivhp8DIXDRSNUGah8wtuk2Y7poTYpo RpZH4vCZ2z2FIdbnw2TszdiIGdVg86oGKTkC13WLCdxmrxkt0n+TJad/4W1Atlcde5Ej W/4MRFGNg6SINCLxryl1cL7qrUml/C3VDkZkhN5+OYyQlgEWp0LZhb+kzSuVttIL7pm4 M5q/nc+J09XxMJ1M8DS09AELS8NtqB9GYdT34AEWDLFucjK6k9oMnxHCMQQu84D7CJ/n lEXXJMSObsdCMIzRu8KFwW7f/Wfl9/vlm6/4q20YaEHHSusmW4plDrd46V0tq0chK0GL 43Kg== X-Gm-Message-State: AOAM532QL4rxqmcw9OGUGUNsVAlBOBnP+xmytb2/bCi4ECLbYyXpyVXJ XJioyFT9h6F1UomDalxoWj0= X-Google-Smtp-Source: ABdhPJxLwspoXfM05fKDAJjGrgJk/lNl9mFqyUZOSnEVwg+LnZWVlVCcVy4z8vIdWiWqu4JkQ+R5aw== X-Received: by 2002:adf:c404:: with SMTP id v4mr2911572wrf.85.1593168073051; Fri, 26 Jun 2020 03:41:13 -0700 (PDT) Received: from CBGR90WXYV0 (54-240-197-236.amazon.com. [54.240.197.236]) by smtp.gmail.com with ESMTPSA id a22sm17026455wmj.9.2020.06.26.03.41.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jun 2020 03:41:12 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Wei Liu'" , "'Jason Andryuk'" References: <20200611032936.350657-1-jandryuk@gmail.com> <20200626101807.za6arkdlah7zsjzc@liuwe-devbox-debian-v2> In-Reply-To: <20200626101807.za6arkdlah7zsjzc@liuwe-devbox-debian-v2> Subject: RE: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy Date: Fri, 26 Jun 2020 11:41:11 +0100 Message-ID: <000501d64ba6$4f8d8f60$eea8ae20$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQLDGQiei5IbGzqMSAjg0ij1F+BV+gLqYT69pvnHS1A= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: xen-devel@lists.xenproject.org, 'Ian Jackson' , marmarek@invisiblethingslab.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Wei Liu > Sent: 26 June 2020 11:18 > To: Jason Andryuk > Cc: xen-devel@lists.xenproject.org; Ian Jackson ; Wei Liu ; > Paul Durrant ; marmarek@invisiblethingslab.com > Subject: Re: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy > > On Wed, Jun 10, 2020 at 11:29:26PM -0400, Jason Andryuk wrote: > > This series addresses some Coverity reports. To handle closing FDs, a > > state struct is introduced to track FDs closed in both main() and > > data_loop(). > > > > v2 changes "Ensure UNIX path NUL terminated" to avoid a warning with > > gcc-10. Also, "Move perror() into listen_socket" and "Move perror() > > into connect_socket" are new. > > > > Jason Andryuk (10): > > vchan-socket-proxy: Ensure UNIX path NUL terminated > > vchan-socket-proxy: Move perror() into listen_socket > > vchan-socket-proxy: Move perror() into connect_socket > > vchan-socket-proxy: Check xs_watch return value > > vchan-socket-proxy: Unify main return value > > vchan-socket-proxy: Use a struct to store state > > vchan-socket-proxy: Switch data_loop() to take state > > vchan-socket-proxy: Set closed FDs to -1 > > vchan-socket-proxy: Cleanup resources on exit > > vchan-socket-proxy: Handle closing shared input/output_fd > > Acked-by: Wei Liu > > Cc Paul. V1 of this series was posted back in May. I consider this > series bug fixes, so they should be applied for 4.14. The risk is low > because vchan-socket-proxy is a small utility used by a small number of > users. > Agreed. Series... Release-acked-by: Paul Durrant > Marek, you gave Review tags in v1. Do they still apply here? > > > > > tools/libvchan/vchan-socket-proxy.c | 183 ++++++++++++++++++---------- > > 1 file changed, 119 insertions(+), 64 deletions(-) > > > > -- > > 2.25.1 > >