From: Paul Durrant <xadimgnik@gmail.com>
To: "'Jan Beulich'" <jbeulich@suse.com>,
"'Jürgen Groß'" <jgross@suse.com>,
"'Kevin Tian'" <kevin.tian@intel.com>,
"'Julien Grall'" <julien@xen.org>,
"'Jun Nakajima'" <jun.nakajima@intel.com>,
"'Wei Liu'" <wl@xen.org>,
"'Ian Jackson'" <ian.jackson@eu.citrix.com>,
"'Daniel De Graaf'" <dgdegra@tycho.nsa.gov>
Cc: "'Stefano Stabellini'" <sstabellini@kernel.org>,
"'Andrew Cooper'" <andrew.cooper3@citrix.com>,
"'George Dunlap'" <george.dunlap@citrix.com>,
"'Anthony PERARD'" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
"'Volodymyr Babchuk'" <Volodymyr_Babchuk@epam.com>,
"'Roger Pau Monné'" <roger.pau@citrix.com>
Subject: RE: [PATCH v10 00/12] Add hypervisor sysfs-like support
Date: Tue, 19 May 2020 09:06:01 +0100 [thread overview]
Message-ID: <000f01d62db4$57181e90$05485bb0$@xen.org> (raw)
In-Reply-To: <305d829f-24a9-1a6d-2131-fed92c22c305@suse.com>
> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: 19 May 2020 08:45
> To: Jürgen Groß <jgross@suse.com>; Kevin Tian <kevin.tian@intel.com>; Julien Grall <julien@xen.org>;
> Jun Nakajima <jun.nakajima@intel.com>; Wei Liu <wl@xen.org>; Ian Jackson <ian.jackson@eu.citrix.com>;
> Daniel De Graaf <dgdegra@tycho.nsa.gov>; Paul Durrant <paul@xen.org>
> Cc: xen-devel@lists.xenproject.org; Stefano Stabellini <sstabellini@kernel.org>; Andrew Cooper
> <andrew.cooper3@citrix.com>; George Dunlap <george.dunlap@citrix.com>; Anthony PERARD
> <anthony.perard@citrix.com>; Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>; Roger Pau Monné
> <roger.pau@citrix.com>
> Subject: Re: [PATCH v10 00/12] Add hypervisor sysfs-like support
>
> On 19.05.2020 09:30, Jürgen Groß wrote:
> > On 19.05.20 09:20, Juergen Gross wrote:
> >>
> >> Juergen Gross (12):
> >> xen/vmx: let opt_ept_ad always reflect the current setting
> >> xen: add a generic way to include binary files as variables
> >> docs: add feature document for Xen hypervisor sysfs-like support
> >> xen: add basic hypervisor filesystem support
> >> libs: add libxenhypfs
> >> tools: add xenfs tool
> >> xen: provide version information in hypfs
> >> xen: add /buildinfo/config entry to hypervisor filesystem
> >> xen: add runtime parameter access support to hypfs
> >> tools/libxl: use libxenhypfs for setting xen runtime parameters
> >> tools/libxc: remove xc_set_parameters()
> >> xen: remove XEN_SYSCTL_set_parameter support
> >>
> >> .gitignore | 6 +
> >> docs/features/hypervisorfs.pandoc | 92 +++++
> >> docs/man/xenhypfs.1.pod | 61 ++++
> >> docs/misc/hypfs-paths.pandoc | 165 +++++++++
> >> tools/Rules.mk | 8 +-
> >> tools/flask/policy/modules/dom0.te | 4 +-
> >> tools/libs/Makefile | 1 +
> >> tools/libs/hypfs/Makefile | 16 +
> >> tools/libs/hypfs/core.c | 536 ++++++++++++++++++++++++++++
> >> tools/libs/hypfs/include/xenhypfs.h | 90 +++++
> >> tools/libs/hypfs/libxenhypfs.map | 10 +
> >> tools/libs/hypfs/xenhypfs.pc.in | 10 +
> >> tools/libxc/include/xenctrl.h | 1 -
> >> tools/libxc/xc_misc.c | 21 --
> >> tools/libxl/Makefile | 3 +-
> >> tools/libxl/libxl.c | 53 ++-
> >> tools/libxl/libxl_internal.h | 1 +
> >> tools/libxl/xenlight.pc.in | 2 +-
> >> tools/misc/Makefile | 6 +
> >> tools/misc/xenhypfs.c | 192 ++++++++++
> >> tools/xl/xl_misc.c | 1 -
> >> xen/arch/arm/traps.c | 3 +
> >> xen/arch/arm/xen.lds.S | 13 +-
> >> xen/arch/x86/hvm/hypercall.c | 3 +
> >> xen/arch/x86/hvm/vmx/vmcs.c | 47 ++-
> >> xen/arch/x86/hvm/vmx/vmx.c | 4 +-
> >> xen/arch/x86/hypercall.c | 3 +
> >> xen/arch/x86/pv/domain.c | 21 +-
> >> xen/arch/x86/pv/hypercall.c | 3 +
> >> xen/arch/x86/xen.lds.S | 12 +-
> >> xen/common/Kconfig | 23 ++
> >> xen/common/Makefile | 13 +
> >> xen/common/grant_table.c | 62 +++-
> >> xen/common/hypfs.c | 452 +++++++++++++++++++++++
> >> xen/common/kernel.c | 84 ++++-
> >> xen/common/sysctl.c | 36 --
> >> xen/drivers/char/console.c | 72 +++-
> >> xen/include/Makefile | 1 +
> >> xen/include/asm-x86/hvm/vmx/vmcs.h | 3 +-
> >> xen/include/public/hypfs.h | 129 +++++++
> >> xen/include/public/sysctl.h | 19 +-
> >> xen/include/public/xen.h | 1 +
> >> xen/include/xen/hypercall.h | 10 +
> >> xen/include/xen/hypfs.h | 123 +++++++
> >> xen/include/xen/kernel.h | 3 +
> >> xen/include/xen/lib.h | 1 -
> >> xen/include/xen/param.h | 126 +++++--
> >> xen/include/xlat.lst | 2 +
> >> xen/include/xsm/dummy.h | 6 +
> >> xen/include/xsm/xsm.h | 6 +
> >> xen/tools/binfile | 43 +++
> >> xen/xsm/dummy.c | 1 +
> >> xen/xsm/flask/Makefile | 5 +-
> >> xen/xsm/flask/flask-policy.S | 16 -
> >> xen/xsm/flask/hooks.c | 9 +-
> >> xen/xsm/flask/policy/access_vectors | 4 +-
> >> 56 files changed, 2445 insertions(+), 193 deletions(-)
> >> create mode 100644 docs/features/hypervisorfs.pandoc
> >> create mode 100644 docs/man/xenhypfs.1.pod
> >> create mode 100644 docs/misc/hypfs-paths.pandoc
> >> create mode 100644 tools/libs/hypfs/Makefile
> >> create mode 100644 tools/libs/hypfs/core.c
> >> create mode 100644 tools/libs/hypfs/include/xenhypfs.h
> >> create mode 100644 tools/libs/hypfs/libxenhypfs.map
> >> create mode 100644 tools/libs/hypfs/xenhypfs.pc.in
> >> create mode 100644 tools/misc/xenhypfs.c
> >> create mode 100644 xen/common/hypfs.c
> >> create mode 100644 xen/include/public/hypfs.h
> >> create mode 100644 xen/include/xen/hypfs.h
> >> create mode 100755 xen/tools/binfile
> >> delete mode 100644 xen/xsm/flask/flask-policy.S
> >>
> >
> > There are some Acks missing on this series, so please have a look at the
> > patches!
> >
> > There are missing especially:
> >
> > - Patch 1: VMX maintainers
> > - Patch 2 + 4: XSM maintainer
> > - Patch 4 + 9: Arm maintainer
> > - Patch 10 + 11: tools maintainers
> >
> > I'd really like the series to go into 4.14 (deadline this Friday).
>
I would also like to see this in 4.14.
> FTR I'm intending to waive the need for the first three of the named
> sets if they don't arrive by Friday (and there I don't mean last
> minute on Friday) - they're not overly intrusive (maybe with the
> exception of the XSM parts in #4) and the series has been pending
> for long enough. I don't feel comfortable to do so for patch 10,
> though; patch 11 looks to be simple enough again.
>
> Paul, as the release manager, please let me know if you disagree.
>
Looking at patch #4, I'm not confident that the XSM parts are complete (e.g. does xen.if need updating?). Also I'd put the new access vector in xen2, since that's where set_parameter currently is (and will be removed from in a later patch), but the xen class does appear to have space so that's really just my taste.
I agree that patch #10 really needs a tools maintainer ack but that patch #11 looks straightforward too so I'd be happy without one for that.
Paul
> Jan
next prev parent reply other threads:[~2020-05-19 8:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 7:20 [PATCH v10 00/12] Add hypervisor sysfs-like support Juergen Gross
2020-05-19 7:20 ` [PATCH v10 01/12] xen/vmx: let opt_ept_ad always reflect the current setting Juergen Gross
2020-05-25 2:23 ` Tian, Kevin
2020-05-19 7:20 ` [PATCH v10 02/12] xen: add a generic way to include binary files as variables Juergen Gross
2020-05-19 7:47 ` Jan Beulich
2020-05-19 7:52 ` Jürgen Groß
2020-05-19 7:58 ` Jan Beulich
2020-05-19 8:14 ` Jürgen Groß
2020-05-19 7:20 ` [PATCH v10 03/12] docs: add feature document for Xen hypervisor sysfs-like support Juergen Gross
2020-05-19 7:20 ` [PATCH v10 04/12] xen: add basic hypervisor filesystem support Juergen Gross
2020-05-21 12:51 ` Julien Grall
2020-05-19 7:20 ` [PATCH v10 05/12] libs: add libxenhypfs Juergen Gross
2020-05-30 15:54 ` Andrew Cooper
2020-06-01 5:27 ` Jürgen Groß
2020-05-19 7:21 ` [PATCH v10 06/12] tools: add xenfs tool Juergen Gross
2020-05-19 7:21 ` [PATCH v10 07/12] xen: provide version information in hypfs Juergen Gross
2020-05-29 8:34 ` Jan Beulich
2020-05-29 9:19 ` Jürgen Groß
2020-05-29 9:53 ` Jan Beulich
2020-05-29 9:56 ` Jürgen Groß
2020-05-19 7:21 ` [PATCH v10 08/12] xen: add /buildinfo/config entry to hypervisor filesystem Juergen Gross
2020-06-02 9:03 ` Andrew Cooper
2020-06-02 10:43 ` Jürgen Groß
2020-05-19 7:21 ` [PATCH v10 09/12] xen: add runtime parameter access support to hypfs Juergen Gross
2020-05-21 12:52 ` Julien Grall
2020-05-19 7:21 ` [PATCH v10 10/12] tools/libxl: use libxenhypfs for setting xen runtime parameters Juergen Gross
2020-05-19 8:17 ` Wei Liu
2020-09-10 20:09 ` Regression: " Andrew Cooper
2020-09-11 5:40 ` Jürgen Groß
2020-05-19 7:21 ` [PATCH v10 11/12] tools/libxc: remove xc_set_parameters() Juergen Gross
2020-05-19 8:09 ` Wei Liu
2020-05-19 7:21 ` [PATCH v10 12/12] xen: remove XEN_SYSCTL_set_parameter support Juergen Gross
2020-05-19 7:30 ` [PATCH v10 00/12] Add hypervisor sysfs-like support Jürgen Groß
2020-05-19 7:45 ` Jan Beulich
2020-05-19 8:06 ` Paul Durrant [this message]
2020-05-25 7:02 ` Jürgen Groß
2020-05-26 8:00 ` Paul Durrant
2020-05-26 8:08 ` Jan Beulich
2020-05-26 8:18 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01d62db4$57181e90$05485bb0$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).