From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A41C433DF for ; Tue, 20 Oct 2020 10:55:25 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F3D7222C8 for ; Tue, 20 Oct 2020 10:55:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L0PsJD1I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F3D7222C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.9088.24440 (Exim 4.92) (envelope-from ) id 1kUpIN-0000BG-VB; Tue, 20 Oct 2020 10:55:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 9088.24440; Tue, 20 Oct 2020 10:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUpIN-0000B9-SF; Tue, 20 Oct 2020 10:55:11 +0000 Received: by outflank-mailman (input) for mailman id 9088; Tue, 20 Oct 2020 10:55:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUpIM-0000B3-OH for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 10:55:10 +0000 Received: from mail-ed1-x541.google.com (unknown [2a00:1450:4864:20::541]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 438461d1-4f92-448c-a00a-471d55fdc3d0; Tue, 20 Oct 2020 10:55:10 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id x1so1361205eds.1 for ; Tue, 20 Oct 2020 03:55:09 -0700 (PDT) Received: from CBGR90WXYV0 (54-240-197-230.amazon.com. [54.240.197.230]) by smtp.gmail.com with ESMTPSA id w22sm2043189edu.15.2020.10.20.03.55.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 03:55:08 -0700 (PDT) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUpIM-0000B3-OH for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 10:55:10 +0000 X-Inumbo-ID: 438461d1-4f92-448c-a00a-471d55fdc3d0 Received: from mail-ed1-x541.google.com (unknown [2a00:1450:4864:20::541]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 438461d1-4f92-448c-a00a-471d55fdc3d0; Tue, 20 Oct 2020 10:55:10 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id x1so1361205eds.1 for ; Tue, 20 Oct 2020 03:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=QDpxbzaKWhiOUrC0mixBdsCIdgIRhodTiFBVVSGm43Q=; b=L0PsJD1IcUwlXwLsX/7U9jFdlOMQ6sPFWxkEi2Tu+gSVmMZ1cCy/Bl4AzHOtFgyaHA WlWCpVUWq3WdD2TMMYUVGyuw5RvoS4w54nZNoPkVjMSw/uTk487BLpDfqKF7ON0NDtfA sGebQA7n8Kz9RCBzp5tDTZfa7QchG2MTdDM8bGo/HUcZVm7QS747ag6VjlyQvDKLHGnb AivRtgx9IAJXHj4x+DMq5nNkor3vnql9O/71bx3InPOnv6BD9MuxALTCVmsHPq4skowF cWMORZQQ1Tmy6T1n30BZVeCffCgr/+qbBKnekN+TydX/jJQ1jKJ6LhUMCqRUgK1gO61e iaZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :thread-index:content-language; bh=QDpxbzaKWhiOUrC0mixBdsCIdgIRhodTiFBVVSGm43Q=; b=soex0GDsOMb/T0Jan+W6qDmArxUCtQQyVetyib9d/0y5ahE80htS3Fhq+Tgns8L7B6 VOgPAKZjs76Fm/7Qrvf+ZBq6Zf4qQtBuyWY/UtdF534oJ9R78gHeeH+VaUPn+JGOVA5T JeCPgdy2kF6vnSH7WV7cGqPFa1FmjFjgs+RH6AMLwTanpn9f7IhIxpkE5d/8zV1OxnY5 eMrRnDFgKuJXW+cUlZMNCgkCBaaTmATgo+MMSuf8SfYTIfBtcd6EOWvF6THBn0xUVEUU Ez0THLYOviUc4H80ywS4GSweTRR3RD/8/joRTaZ5NI8fyVjrJpwcW1C0mPKOZg6erSSp W6/Q== X-Gm-Message-State: AOAM531u4jCAhj16nh9RO7BGUqaO0YrZ9sS+kmrYnfbMArMkEVq2hRNu AldDBgddpFtYFQ3zbRTxqmY= X-Google-Smtp-Source: ABdhPJxSxTpqy/Es07re/7wJNHCZ7KAS/02YaDdE7x4y/1z3o2CSFcX81IYlYZGZ3+oJ+MiuhfhEUQ== X-Received: by 2002:a50:d751:: with SMTP id i17mr2128076edj.337.1603191309187; Tue, 20 Oct 2020 03:55:09 -0700 (PDT) Received: from CBGR90WXYV0 (54-240-197-230.amazon.com. [54.240.197.230]) by smtp.gmail.com with ESMTPSA id w22sm2043189edu.15.2020.10.20.03.55.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 03:55:08 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" Reply-To: To: "'Oleksandr Tyshchenko'" , Cc: "'Oleksandr Tyshchenko'" , "'Jan Beulich'" , "'Andrew Cooper'" , =?utf-8?Q?'Roger_Pau_Monn=C3=A9'?= , "'Wei Liu'" , "'George Dunlap'" , "'Ian Jackson'" , "'Julien Grall'" , "'Stefano Stabellini'" , "'Jun Nakajima'" , "'Kevin Tian'" , "'Julien Grall'" References: <1602780274-29141-1-git-send-email-olekstysh@gmail.com> <1602780274-29141-12-git-send-email-olekstysh@gmail.com> In-Reply-To: <1602780274-29141-12-git-send-email-olekstysh@gmail.com> Subject: RE: [PATCH V2 11/23] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu Date: Tue, 20 Oct 2020 11:55:07 +0100 Message-ID: <004f01d6a6cf$79d0daa0$6d728fe0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFqp5MaNUj6MKEiN9RM6S6pfA5bVAEW73X1qm+YG6A= Content-Language: en-gb > -----Original Message----- > From: Oleksandr Tyshchenko > Sent: 15 October 2020 17:44 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Paul Durrant = ; Jan Beulich > ; Andrew Cooper ; Roger = Pau Monn=C3=A9 > ; Wei Liu ; George Dunlap = ; Ian Jackson > ; Julien Grall ; Stefano = Stabellini ; Jun > Nakajima ; Kevin Tian ; = Julien Grall > > Subject: [PATCH V2 11/23] xen/ioreq: Move x86's io_completion/io_req = fields to struct vcpu >=20 > From: Oleksandr Tyshchenko >=20 > The IOREQ is a common feature now and these fields will be used > on Arm as is. Move them to common struct vcpu as a part of new > struct vcpu_io. Also move enum hvm_io_completion to xen/sched.h > and remove "hvm" prefixes. >=20 > This patch completely removes layering violation in the common code. >=20 > Signed-off-by: Oleksandr Tyshchenko > CC: Julien Grall >=20 > --- > Please note, this is a split/cleanup/hardening of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" >=20 > *** > I was thinking that it may be better to place these two fields > into struct vcpu directly (without intermediate "io" struct). > I think, this way the code which operates with these fields > would become cleaner. Another possible option would be either > to rename "io" struct (I failed to think of a better name) or > to drop(replace?) duplicating "io" prefixes from these fields. Just drop the 'io_' prefix from the field names. Paul