From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF2D0C433DF for ; Wed, 17 Jun 2020 08:39:58 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF1EC2100A for ; Wed, 17 Jun 2020 08:39:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FT5/HfzH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF1EC2100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlTbo-0003Ju-QT; Wed, 17 Jun 2020 08:39:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlTbn-0003J6-0u for xen-devel@lists.xenproject.org; Wed, 17 Jun 2020 08:39:47 +0000 X-Inumbo-ID: 18e58cc6-b076-11ea-bca7-bc764e2007e4 Received: from mail-wm1-x341.google.com (unknown [2a00:1450:4864:20::341]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 18e58cc6-b076-11ea-bca7-bc764e2007e4; Wed, 17 Jun 2020 08:39:46 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id g10so1007247wmh.4 for ; Wed, 17 Jun 2020 01:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=+wdC9mW3JSrWfdn3V4wPeinzlJyZ8c3Jf3+qdLTGosI=; b=FT5/HfzHHgg2TwcVBJ/08E6KZRbX4wHUg8PPwIxtSUQcZ3eWONSvIxmv6faKMmaYMY Wn3wk64gwz5Ru+Gbm259jzZuKyCU6ManqaqEExqE6A9mboYh0mTNrY+ABOJ0GA32yHxr Og31o8FPzWK8inNSUpXxhnsVUDgQxOOZMHk1RpaxmPBYGrsxpFetfFsMDUaB/YN0TSiE 6C+KlBG87QQraTUf8q5iIV9MFu8EVnLihCdIYnoZOQlin7hEO0U6LJXwygaXQq6edGoQ C54GYTKkzyZK1TtiNymzUzYicGOyDGZqf08VAykNbOxVTOb7sBKMpqfCCuVE5Y6bsrsz C3Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=+wdC9mW3JSrWfdn3V4wPeinzlJyZ8c3Jf3+qdLTGosI=; b=H/QatnBi0rfk/UPxMxJ20b6EFCtMHdJ/2NWq2EQlTmNoGGbXYVff+8CucnW8zAGlN2 rzjp9LYO/r+PrzwHE24iYk6+S8uhcE4x6e8+INJNhGO5q0y5+BNYOjkcn1dI0cX1zWts e5HHpxExCRvWaBscC6CQ/vKBC5dmTFVdTHu2qac3SQ+3BsiQ/oILOmw0mmPmZvjkRI58 7YxSUYZ9okibRUq0WyPYl9+cRAtCvpCTPFiTxqJHld6jHCt6bohg/mhyfrR9tZXtGBBj 1ysY1Uigr15tKEAkhIiIr2GrbLXnUyvS61rjBYwcpzaJ3W6KXVo25aY1RtODzT6EG5B6 n9nQ== X-Gm-Message-State: AOAM533Vsjtx/eEddg+EFIImoIP30u55P1hG5Uf2Wv8+At4dvrSEf6A4 vEeFUZxFl2zYBDCSZ7dQZYk= X-Google-Smtp-Source: ABdhPJyCl2D1rgnxUWSlyoAhU4WIeJGpGNIxu1nPmBqdBfpkJFANSFEdvywjqyubBzyX/Df3bIa5WQ== X-Received: by 2002:a1c:6884:: with SMTP id d126mr7371345wmc.121.1592383185461; Wed, 17 Jun 2020 01:39:45 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.187]) by smtp.gmail.com with ESMTPSA id g19sm7037742wmh.29.2020.06.17.01.39.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jun 2020 01:39:45 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Igor Druzhinin'" , References: <1592360353-31231-1-git-send-email-igor.druzhinin@citrix.com> In-Reply-To: <1592360353-31231-1-git-send-email-igor.druzhinin@citrix.com> Subject: RE: [PATCH for-4.14 v3] tools/xen-ucode: return correct exit code on failed microcode update Date: Wed, 17 Jun 2020 09:39:43 +0100 Message-ID: <005b01d64482$da189650$8e49c2f0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQGeNywcRe2CjUFC+SqYd4wUtfCSSqlMlzSQ X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: ian.jackson@eu.citrix.com, xadimgnik@gmail.com, wl@xen.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Igor Druzhinin > Sent: 17 June 2020 03:19 > To: xen-devel@lists.xenproject.org > Cc: ian.jackson@eu.citrix.com; wl@xen.org; xadimgnik@gmail.com; Igor Druzhinin > > Subject: [PATCH for-4.14 v3] tools/xen-ucode: return correct exit code on failed microcode update > > Otherwise it's difficult to know if operation failed inside the automation. > > While at it, also switch to returning 1 and 2 instead of errno to avoid > incompatibilies between errno and special exit code numbers. > > Signed-off-by: Igor Druzhinin Reviewed-by: Paul Durrant Release-acked-by: Paul Durrant > --- > Changes in v3: > - conventionally return 1 and 2 instead of errno as exit code > --- > tools/misc/xen-ucode.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tools/misc/xen-ucode.c b/tools/misc/xen-ucode.c > index 0c257f4..ad32fac 100644 > --- a/tools/misc/xen-ucode.c > +++ b/tools/misc/xen-ucode.c > @@ -25,7 +25,7 @@ int main(int argc, char *argv[]) > fprintf(stderr, > "xen-ucode: Xen microcode updating tool\n" > "Usage: %s \n", argv[0]); > - return 0; > + exit(2); > } > > filename = argv[1]; > @@ -34,14 +34,14 @@ int main(int argc, char *argv[]) > { > fprintf(stderr, "Could not open %s. (err: %s)\n", > filename, strerror(errno)); > - return errno; > + exit(1); > } > > if ( fstat(fd, &st) != 0 ) > { > fprintf(stderr, "Could not get the size of %s. (err: %s)\n", > filename, strerror(errno)); > - return errno; > + exit(1); > } > > len = st.st_size; > @@ -49,7 +49,7 @@ int main(int argc, char *argv[]) > if ( buf == MAP_FAILED ) > { > fprintf(stderr, "mmap failed. (error: %s)\n", strerror(errno)); > - return errno; > + exit(1); > } > > xch = xc_interface_open(NULL, NULL, 0); > @@ -57,20 +57,23 @@ int main(int argc, char *argv[]) > { > fprintf(stderr, "Error opening xc interface. (err: %s)\n", > strerror(errno)); > - return errno; > + exit(1); > } > > ret = xc_microcode_update(xch, buf, len); > if ( ret ) > + { > fprintf(stderr, "Failed to update microcode. (err: %s)\n", > strerror(errno)); > + exit(1); > + } > > xc_interface_close(xch); > > if ( munmap(buf, len) ) > { > printf("Could not unmap: %d(%s)\n", errno, strerror(errno)); > - return errno; > + exit(1); > } > close(fd); > > -- > 2.7.4