From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A00FC5519F for ; Wed, 18 Nov 2020 12:29:45 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89AD721D91 for ; Wed, 18 Nov 2020 12:29:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y03YSM6V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89AD721D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.29800.59473 (Exim 4.92) (envelope-from ) id 1kfMaS-00007k-6B; Wed, 18 Nov 2020 12:29:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 29800.59473; Wed, 18 Nov 2020 12:29:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfMaS-00007d-2H; Wed, 18 Nov 2020 12:29:24 +0000 Received: by outflank-mailman (input) for mailman id 29800; Wed, 18 Nov 2020 12:29:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfMaQ-00006j-Iy for xen-devel@lists.xenproject.org; Wed, 18 Nov 2020 12:29:22 +0000 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 152eb89c-3e99-4d2b-af0c-7ce439501a6e; Wed, 18 Nov 2020 12:29:21 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id u12so2087732wrt.0 for ; Wed, 18 Nov 2020 04:29:21 -0800 (PST) Received: from CBGR90WXYV0 (host109-146-187-185.range109-146.btcentralplus.com. [109.146.187.185]) by smtp.gmail.com with ESMTPSA id v189sm3989075wmg.14.2020.11.18.04.29.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2020 04:29:20 -0800 (PST) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfMaQ-00006j-Iy for xen-devel@lists.xenproject.org; Wed, 18 Nov 2020 12:29:22 +0000 X-Inumbo-ID: 152eb89c-3e99-4d2b-af0c-7ce439501a6e Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 152eb89c-3e99-4d2b-af0c-7ce439501a6e; Wed, 18 Nov 2020 12:29:21 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id u12so2087732wrt.0 for ; Wed, 18 Nov 2020 04:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=a7q5y5kwEhcoxThrF6U+u43rpWzWheQIW/yaAeO7GWk=; b=Y03YSM6VsBDbA8isiYP2X7gNhTUXsgwisKUzu/AFjfWh8SOPdW9BFDUg17Ow2z9BUE 9mPjR+fx1oFvOA+ltrdad44VmfDZVodl1zNibG0PVADnh18Dih3/fOnLkazqJRC9faUa TAjdlcUKYeifjYg48KeDjPOWmoGPXIR0og1UtaGZA/uRTQg1bRHdve61/8xcCMdtRrSK 3Oea7OrS0tvK0QWszCaAN13MVQIh834b7iK3gRgy17+fKjm1CxxLCMAA86SUI86e3NWp j7xx1FDt0+bfzhMfmE+GcSRJPVkR31d4I4y2n7UfMM34k5m8KRWFK4xIJ6979QVIbeb7 oLCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=a7q5y5kwEhcoxThrF6U+u43rpWzWheQIW/yaAeO7GWk=; b=tPxW3FVehEK54vDa9+i6CsGt2BV0M5MtroeDwzgecMyY2gH11stU00KIbUHOZnyIrz WNb+A68CczBJlfvKI6dzxoU8oxDK3yWGfXXjnlWseVq6o549UaA/6tlkADrWQCQ6r6Wh oZZyuuVLbor/WbBTRglKJlLqgYzb+i1zWmqfzD2y4LIJ61W5l3qkZczMoU/pLnCmzCTc OWdbhwubLR+fY7ZuzfDjgBKYUR8Fet8Xeu9qTxdgDFy1VVSQqRGMbplzJo+T3dvdXPFa xpgw/x8+Ow6cSJosfOxuFzsA+pDKiaiselI4INH2De71daeZuztf1jHvaNComhbpBmjk 3BaQ== X-Gm-Message-State: AOAM5331AxjGXgFuCHJkevVKm4MFqwbx/mMint4mfAvTJRhZZvNNXoRf UsD6Wh6YlWvjS6hoZfW4bVs= X-Google-Smtp-Source: ABdhPJz9jKDbFhsLf/E2gE9cy8bgu/f44QQZAaG7eBduyPPsBCYoA8OOtC7WLNOWbp969e8uD6+ZKw== X-Received: by 2002:adf:ffc9:: with SMTP id x9mr4667501wrs.148.1605702560655; Wed, 18 Nov 2020 04:29:20 -0800 (PST) Received: from CBGR90WXYV0 (host109-146-187-185.range109-146.btcentralplus.com. [109.146.187.185]) by smtp.gmail.com with ESMTPSA id v189sm3989075wmg.14.2020.11.18.04.29.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2020 04:29:20 -0800 (PST) From: Paul Durrant X-Google-Original-From: "Paul Durrant" Reply-To: To: "'Oleksandr'" Cc: , "'Oleksandr Tyshchenko'" , "'Jan Beulich'" , "'Andrew Cooper'" , =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= , "'Wei Liu'" , "'George Dunlap'" , "'Ian Jackson'" , "'Julien Grall'" , "'Stefano Stabellini'" , "'Julien Grall'" References: <1602780274-29141-1-git-send-email-olekstysh@gmail.com> <1602780274-29141-8-git-send-email-olekstysh@gmail.com> <79588865-3f28-5436-0763-cb8ee0b87262@gmail.com> In-Reply-To: <79588865-3f28-5436-0763-cb8ee0b87262@gmail.com> Subject: RE: [PATCH V2 07/23] xen/ioreq: Move x86's ioreq_gfn(server) to struct domain Date: Wed, 18 Nov 2020 12:29:19 -0000 Message-ID: <00b101d6bda6$7055f2b0$5101d810$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQFqp5MaNUj6MKEiN9RM6S6pfA5bVAHOAtspAs5yhsWqgRnfwA== > -----Original Message----- > From: Oleksandr > Sent: 18 November 2020 12:09 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko = ; Jan Beulich > ; Andrew Cooper ; Roger = Pau Monn=C3=A9 > ; Wei Liu ; George Dunlap = ; Ian Jackson > ; Julien Grall ; Stefano = Stabellini ; > Julien Grall > Subject: Re: [PATCH V2 07/23] xen/ioreq: Move x86's ioreq_gfn(server) = to struct domain >=20 >=20 > Hi Paul. >=20 > > --- a/xen/include/xen/sched.h > > +++ b/xen/include/xen/sched.h > > @@ -314,6 +314,8 @@ struct sched_unit { > > > > struct evtchn_port_ops; > > > > +#define MAX_NR_IOREQ_SERVERS 8 > > + > > struct domain > > { > > domid_t domain_id; > > @@ -521,6 +523,21 @@ struct domain > > /* Argo interdomain communication support */ > > struct argo_domain *argo; > > #endif > > + > > +#ifdef CONFIG_IOREQ_SERVER > > + /* Guest page range used for non-default ioreq servers */ > > + struct { > > + unsigned long base; > > + unsigned long mask; > > + unsigned long legacy_mask; /* indexed by HVM param number = */ > > + } ioreq_gfn; >=20 > I assume the whole ioreq_gfn struct doesn't need to be here. According > to the new requirement to leave legacy interface x86 specific, >=20 > these fields won't be used in common code anymore. I will move = ioreq_gfn > struct back to hvm_domain. Please confirm. Yes, leave it where it is in struct hvm_domain. Paul >=20 >=20 > > + > > + /* Lock protects all other values in the sub-struct and the = default */ > > + struct { > > + spinlock_t lock; > > + struct ioreq_server *server[MAX_NR_IOREQ_SERVERS]; > > + } ioreq_server; > > +#endif > > }; > > > > static inline struct page_list_head *page_to_list( >=20 > -- > Regards, >=20 > Oleksandr Tyshchenko