From: Julien Grall <julien@xen.org>
To: Luca Fancellu <luca.fancellu@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>,
Bertrand Marquis <bertrand.marquis@arm.com>,
wei.chen@arm.com, Ian Jackson <iwj@xenproject.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64
Date: Wed, 10 Nov 2021 13:36:10 +0000 [thread overview]
Message-ID: <010fa02f-e561-e7a8-9638-5246db9166b4@xen.org> (raw)
In-Reply-To: <3B8E0C6E-0522-4F73-B6C2-827FA45C87BA@arm.com>
Hi Luca,
On 10/11/2021 13:05, Luca Fancellu wrote:
> I thought having the EFI_FILE_HANDLE global in efi-boot.h was a “no go”, but if it’s not then instead of
> calling get_parent_handle in efi_check_dt_boot (that is the main issue with EDK2+Grub2), we can do
> something like this:
fs_dir_handle is only used by callees of efi_check_boot_dt_boot(). So
the global variable is not an option for me because the risk is not
worth it (it is easy to misuse a global variable).
Instead, I think fs_dir_handle should be an argument of
allocate_module_file() and propagated up to the first call in
efi_check_dt_boot().
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-11-10 13:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 14:12 [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64 Luca Fancellu
2021-11-04 14:33 ` Bertrand Marquis
2021-11-04 14:44 ` Ian Jackson
2021-11-04 16:36 ` Jan Beulich
2021-11-04 20:56 ` Stefano Stabellini
2021-11-04 21:07 ` Luca Fancellu
2021-11-04 21:35 ` Stefano Stabellini
2021-11-04 21:43 ` Luca Fancellu
2021-11-04 21:50 ` Stefano Stabellini
2021-11-05 7:35 ` Jan Beulich
2021-11-05 15:33 ` Stefano Stabellini
2021-11-08 7:25 ` Jan Beulich
2021-11-09 2:11 ` Stefano Stabellini
2021-11-09 9:23 ` Luca Fancellu
2021-11-09 11:01 ` Jan Beulich
2021-11-09 11:00 ` Jan Beulich
2021-11-09 21:52 ` Stefano Stabellini
2021-11-09 22:31 ` Julien Grall
2021-11-10 7:40 ` Jan Beulich
2021-11-10 13:05 ` Luca Fancellu
2021-11-10 13:36 ` Julien Grall [this message]
2021-11-10 14:02 ` Luca Fancellu
2021-11-15 18:57 ` Julien Grall
2021-11-15 22:00 ` Stefano Stabellini
2021-11-16 8:36 ` Luca Fancellu
2021-11-16 15:08 ` Ian Jackson
2021-11-16 16:11 ` Jan Beulich
2021-11-16 16:23 ` Julien Grall
2021-11-05 7:32 ` Jan Beulich
2021-11-05 7:27 ` Jan Beulich
2021-11-04 20:51 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010fa02f-e561-e7a8-9638-5246db9166b4@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=luca.fancellu@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).