From: Julien Grall <julien@xen.org>
To: Ian Jackson <iwj@xenproject.org>
Cc: "Jan Beulich" <jbeulich@suse.com>,
"Jürgen Groß" <jgross@suse.com>,
raphning@amazon.co.uk, "Julien Grall" <jgrall@amazon.com>,
"Wei Liu" <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()
Date: Sat, 6 Mar 2021 19:37:45 +0000 [thread overview]
Message-ID: <0249af89-ced0-0f7f-d370-9ffade6b1678@xen.org> (raw)
In-Reply-To: <24642.14600.124181.19574@mariner.uk.xensource.com>
Hi Ian,
On 05/03/2021 13:58, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"):
>> Urgh, you are right. Actually, the extern was added recently by Anthony:
>>
>> dacdbf7088d6a3705a9831e73991c2b14c519a65 ("tools/xenstore: mark variable
>> in header as extern")
>>
>> I completely forgot it despite I needed to backport the patch to our
>> downstream Xen.
>
> How horrible.
>
> Maybe we could add a comment to the code, next to the declaration,
> about this crazy situation.
Would the following comment work for you?
/* Function pointer as xprintf() can be configured at runtime. */
I can fold it in my patch while committing.
Cheers,
>
> Ian.
>
--
Julien Grall
next prev parent reply other threads:[~2021-03-06 19:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 12:40 [PATCH for-4.15 0/2] xenstore: Check format printf Julien Grall
2021-03-05 12:40 ` [PATCH for-4.15 1/2] tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h Julien Grall
2021-03-05 13:00 ` Jürgen Groß
2021-03-05 13:24 ` Ian Jackson
2021-03-05 12:40 ` [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() Julien Grall
2021-03-05 13:01 ` Jürgen Groß
2021-03-05 13:27 ` Ian Jackson
2021-03-05 13:32 ` Julien Grall
2021-03-05 13:45 ` Jan Beulich
2021-03-05 13:48 ` Andrew Cooper
2021-03-05 13:48 ` Julien Grall
2021-03-05 13:58 ` Ian Jackson
2021-03-06 19:37 ` Julien Grall [this message]
2021-03-08 9:44 ` Ian Jackson
2021-03-11 9:48 ` Julien Grall
2021-03-05 13:24 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0249af89-ced0-0f7f-d370-9ffade6b1678@xen.org \
--to=julien@xen.org \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=jgross@suse.com \
--cc=raphning@amazon.co.uk \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).