From: "Durrant, Paul" <pdurrant@amazon.com>
To: "Jürgen Groß" <jgross@suse.com>,
"Park, Seongjae" <sjpark@amazon.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"sj38.park@gmail.com" <sj38.park@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure
Date: Mon, 9 Dec 2019 09:46:25 +0000 [thread overview]
Message-ID: <026ba79524da43648371e5bca437a5e4@EX13D32EUC003.ant.amazon.com> (raw)
In-Reply-To: <954f7beb-9d40-253e-260b-4750809bf808@suse.com>
> -----Original Message-----
> From: Jürgen Groß <jgross@suse.com>
> Sent: 09 December 2019 09:39
> To: Park, Seongjae <sjpark@amazon.com>; axboe@kernel.dk;
> konrad.wilk@oracle.com; roger.pau@citrix.com
> Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; Durrant,
> Paul <pdurrant@amazon.com>; sj38.park@gmail.com; xen-
> devel@lists.xenproject.org
> Subject: Re: [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory
> pressure
>
> On 09.12.19 09:58, SeongJae Park wrote:
> > Each `blkif` has a free pages pool for the grant mapping. The size of
> > the pool starts from zero and be increased on demand while processing
> > the I/O requests. If current I/O requests handling is finished or 100
> > milliseconds has passed since last I/O requests handling, it checks and
> > shrinks the pool to not exceed the size limit, `max_buffer_pages`.
> >
> > Therefore, `blkfront` running guests can cause a memory pressure in the
> > `blkback` running guest by attaching a large number of block devices and
> > inducing I/O.
>
> I'm having problems to understand how a guest can attach a large number
> of block devices without those having been configured by the host admin
> before.
>
> If those devices have been configured, dom0 should be ready for that
> number of devices, e.g. by having enough spare memory area for ballooned
> pages.
>
> So either I'm missing something here or your reasoning for the need of
> the patch is wrong.
>
I think the underlying issue is that persistent grant support is hogging memory in the backends, thereby compromising scalability. IIUC this patch is essentially a band-aid to get back to the scalability that was possible before persistent grant support was added. Ultimately the right answer should be to get rid of persistent grants support and use grant copy, but such a change is clearly more invasive and would need far more testing.
Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-09 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 8:58 [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure SeongJae Park
2019-12-09 8:58 ` [Xen-devel] [PATCH v3 1/1] xen/blkback: Squeeze page pools if a memory pressure is detected SeongJae Park
2019-12-09 9:39 ` [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure Jürgen Groß
2019-12-09 9:46 ` Durrant, Paul [this message]
2019-12-09 10:15 ` Jürgen Groß
2019-12-09 10:52 ` SeongJae Park
2019-12-09 11:08 ` Jürgen Groß
2019-12-09 11:32 ` SeongJae Park
2019-12-09 10:23 ` SeongJae Park
2019-12-09 10:29 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=026ba79524da43648371e5bca437a5e4@EX13D32EUC003.ant.amazon.com \
--to=pdurrant@amazon.com \
--cc=axboe@kernel.dk \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).