From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B1AC433FE for ; Mon, 7 Dec 2020 11:47:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A9DB23340 for ; Mon, 7 Dec 2020 11:47:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A9DB23340 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.46361.82277 (Exim 4.92) (envelope-from ) id 1kmEz7-00016Z-Mx; Mon, 07 Dec 2020 11:47:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 46361.82277; Mon, 07 Dec 2020 11:47:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmEz7-00016S-Jq; Mon, 07 Dec 2020 11:47:17 +0000 Received: by outflank-mailman (input) for mailman id 46361; Mon, 07 Dec 2020 11:47:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmEz5-00016N-Qg for xen-devel@lists.xenproject.org; Mon, 07 Dec 2020 11:47:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab0c550b-b7da-4a25-a2ce-254e9dea003e; Mon, 07 Dec 2020 11:47:15 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3DEEBAC9A; Mon, 7 Dec 2020 11:47:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab0c550b-b7da-4a25-a2ce-254e9dea003e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607341634; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kg3gDdT3ADiFHvwSa2dcT46uq2ybzUoNndm7KF8yLig=; b=Ew6afyminPVSFaXdqYWqFVp29Mp0GC36fx3IVefCbxJ7xzf9EcF/im5UeTwNK5Ui9qifHR Fmw6lQ0pZTDlwRYoar/vKaVG+8WLGqpbl05cwy9RVuAM3DoYRA4bSTumCgluEjyZlrWSYf 4gwNijtNR8WWtIaPMxop9dJx/jDTAbc= Subject: Re: [PATCH V3 05/23] xen/ioreq: Make x86's hvm_ioreq_needs_completion() common To: Oleksandr Tyshchenko Cc: Oleksandr Tyshchenko , Paul Durrant , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Julien Grall , Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org References: <1606732298-22107-1-git-send-email-olekstysh@gmail.com> <1606732298-22107-6-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: <033af196-1338-54a6-1ec3-416df27337fa@suse.com> Date: Mon, 7 Dec 2020 12:47:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <1606732298-22107-6-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 30.11.2020 11:31, Oleksandr Tyshchenko wrote: > --- a/xen/include/xen/ioreq.h > +++ b/xen/include/xen/ioreq.h > @@ -21,6 +21,13 @@ > > #include > > +static inline bool ioreq_needs_completion(const ioreq_t *ioreq) > +{ > + return ioreq->state == STATE_IOREQ_READY && > + !ioreq->data_is_ptr && > + (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != IOREQ_WRITE); > +} > + > #define HANDLE_BUFIOREQ(s) \ > ((s)->bufioreq_handling != HVM_IOREQSRV_BUFIOREQ_OFF) Personally I would have suggested to keep the #define first, but I see you've already got Paul's R-b. Applicable parts Acked-by: Jan Beulich Jan