From: Paul Durrant <Paul.Durrant@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
Jan Beulich <jbeulich@suse.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 07/11] ioreq: allow registering internal ioreq server handler
Date: Tue, 10 Sep 2019 13:12:37 +0000 [thread overview]
Message-ID: <04871248729b4790ac6ac18688d305cf@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <20190903161428.7159-8-roger.pau@citrix.com>
> -----Original Message-----
> From: Roger Pau Monne <roger.pau@citrix.com>
> Sent: 03 September 2019 17:14
> To: xen-devel@lists.xenproject.org
> Cc: Roger Pau Monne <roger.pau@citrix.com>; Paul Durrant <Paul.Durrant@citrix.com>; Jan Beulich
> <jbeulich@suse.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>
> Subject: [PATCH v2 07/11] ioreq: allow registering internal ioreq server handler
>
> Provide a routine to register the handler for an internal ioreq
> server.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Changes since v1:
> - Allow to provide an opaque data parameter to pass to the handler.
> - Allow changing the handler as long as the server is not enabled.
> ---
> xen/arch/x86/hvm/ioreq.c | 35 +++++++++++++++++++++++++++++++++
> xen/include/asm-x86/hvm/ioreq.h | 4 ++++
> 2 files changed, 39 insertions(+)
>
> diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
> index 8331a89eae..6339e5f884 100644
> --- a/xen/arch/x86/hvm/ioreq.c
> +++ b/xen/arch/x86/hvm/ioreq.c
> @@ -485,6 +485,41 @@ static int hvm_add_ioreq_gfn(struct hvm_ioreq_server *s, bool buf)
> return rc;
> }
>
> +int hvm_add_ioreq_handler(struct domain *d, ioservid_t id,
I did ask for 'hvm_set_ioreq_handler()'. I think it makes more sense as there's no corresponding 'hvm_remove_ioreq_handler()'.
> + int (*handler)(struct vcpu *v, ioreq_t *, void *),
> + void *data)
> +{
> + struct hvm_ioreq_server *s;
> + int rc = 0;
> +
> + if ( !hvm_ioreq_is_internal(id) )
> + {
> + rc = -EINVAL;
> + goto out;
You just want to return here because you're not holding the lock.
Paul
> + }
> +
> + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock);
> + s = get_ioreq_server(d, id);
> + if ( !s )
> + {
> + rc = -ENOENT;
> + goto out;
> + }
> + if ( s->enabled )
> + {
> + rc = -EBUSY;
> + goto out;
> + }
> +
> + s->handler = handler;
> + s->data = data;
> +
> + out:
> + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock);
> +
> + return rc;
> +}
> +
> static void hvm_update_ioreq_evtchn(struct hvm_ioreq_server *s,
> struct hvm_ioreq_vcpu *sv)
> {
> diff --git a/xen/include/asm-x86/hvm/ioreq.h b/xen/include/asm-x86/hvm/ioreq.h
> index c3917aa74d..90cc2aa938 100644
> --- a/xen/include/asm-x86/hvm/ioreq.h
> +++ b/xen/include/asm-x86/hvm/ioreq.h
> @@ -54,6 +54,10 @@ unsigned int hvm_broadcast_ioreq(ioreq_t *p, bool buffered);
>
> void hvm_ioreq_init(struct domain *d);
>
> +int hvm_add_ioreq_handler(struct domain *d, ioservid_t id,
> + int (*handler)(struct vcpu *v, ioreq_t *, void *),
> + void *data);
> +
> static inline bool hvm_ioreq_is_internal(unsigned int id)
> {
> ASSERT(id < MAX_NR_IOREQ_SERVERS);
> --
> 2.22.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-10 13:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:14 [Xen-devel] [PATCH v2 00/11] ioreq: add support for internal servers Roger Pau Monne
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path cleanup Roger Pau Monne
2019-09-10 10:44 ` Paul Durrant
2019-09-10 13:28 ` Jan Beulich
2019-09-10 13:33 ` Roger Pau Monné
2019-09-10 13:35 ` Jan Beulich
2019-09-10 13:42 ` Roger Pau Monné
2019-09-10 13:53 ` Paul Durrant
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 02/11] ioreq: terminate cf8 handling at hypervisor level Roger Pau Monne
2019-09-03 17:13 ` Andrew Cooper
2019-09-04 7:49 ` Roger Pau Monné
2019-09-04 8:00 ` Roger Pau Monné
2019-09-04 8:04 ` Jan Beulich
2019-09-04 9:46 ` Paul Durrant
2019-09-04 13:39 ` Roger Pau Monné
2019-09-04 13:56 ` Paul Durrant
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 03/11] ioreq: switch selection and forwarding to use ioservid_t Roger Pau Monne
2019-09-10 12:31 ` Paul Durrant
2019-09-20 10:47 ` Jan Beulich
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 04/11] ioreq: add fields to allow internal ioreq servers Roger Pau Monne
2019-09-10 12:34 ` Paul Durrant
2019-09-20 10:53 ` Jan Beulich
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 05/11] ioreq: add internal ioreq initialization support Roger Pau Monne
2019-09-10 12:59 ` Paul Durrant
2019-09-26 10:49 ` Roger Pau Monné
2019-09-26 10:58 ` Paul Durrant
2019-09-20 11:15 ` Jan Beulich
2019-09-26 10:51 ` Roger Pau Monné
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 06/11] ioreq: allow dispatching ioreqs to internal servers Roger Pau Monne
2019-09-10 13:06 ` Paul Durrant
2019-09-20 11:35 ` Jan Beulich
2019-09-26 11:14 ` Roger Pau Monné
2019-09-26 13:17 ` Jan Beulich
2019-09-26 13:46 ` Roger Pau Monné
2019-09-26 15:13 ` Jan Beulich
2019-09-26 15:59 ` Roger Pau Monné
2019-09-27 8:17 ` Paul Durrant
2019-09-26 16:36 ` Roger Pau Monné
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 07/11] ioreq: allow registering internal ioreq server handler Roger Pau Monne
2019-09-10 13:12 ` Paul Durrant [this message]
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 08/11] ioreq: allow decoding accesses to MMCFG regions Roger Pau Monne
2019-09-10 13:37 ` Paul Durrant
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 09/11] vpci: register as an internal ioreq server Roger Pau Monne
2019-09-10 13:49 ` Paul Durrant
2019-09-26 15:07 ` Roger Pau Monné
2019-09-27 8:29 ` Paul Durrant
2019-09-27 8:45 ` Roger Pau Monné
2019-09-27 9:01 ` Paul Durrant
2019-09-27 10:46 ` Roger Pau Monné
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 10/11] ioreq: split the code to detect PCI config space accesses Roger Pau Monne
2019-09-10 14:06 ` Paul Durrant
2019-09-26 16:05 ` Roger Pau Monné
2019-09-03 16:14 ` [Xen-devel] [PATCH v2 11/11] ioreq: provide support for long-running operations Roger Pau Monne
2019-09-10 14:14 ` Paul Durrant
2019-09-10 14:28 ` Roger Pau Monné
2019-09-10 14:40 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04871248729b4790ac6ac18688d305cf@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).