From: Sander Eikelenboom <linux@eikelenboom.it>
To: Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached
Date: Mon, 30 Sep 2019 20:10:16 +0200 [thread overview]
Message-ID: <0590e03b-a455-1aa3-40f3-2ef96827d669@eikelenboom.it> (raw)
In-Reply-To: <20190930172327.784520-3-anthony.perard@citrix.com>
On 30/09/2019 19:23, Anthony PERARD wrote:
> Before the problematic commit, libxl used to ignore error when
> destroying (force == true) a passthrough device. If the DM failed to
> detach the pci device within the allowed time, the timed out error
> raised skip part of pci_remove_*, but also raise the error up to the
> caller of libxl__device_pci_destroy_all, libxl__destroy_domid, and
> thus the destruction of the domain fails.
>
> When a *pci_destroy* function is called (so we have force=true), error
> should mostly be ignored. If the DM didn't confirmed that the device
> is removed, we will print a warning and keep going if force=true.
> The patch reorder the functions so that pci_remove_timeout() calls
> pci_remove_detatched() like it's done when DM calls are successful.
>
> We also clean the QMP states and associated timeouts earlier, as soon
> as they are not needed anymore.
>
> Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> Fixes: fae4880c45fe015e567afa223f78bf17a6d98e1b
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Hi Anthony,
Just tested and it works for me, thanks !
--
Sander
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-30 18:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 17:23 [Xen-devel] [PATCH 0/2] libxl fixes with pci passthrough Anthony PERARD
2019-09-30 17:23 ` [Xen-devel] [PATCH 1/2] libxl_pci: Don't ignore PCI PT error at guest creation Anthony PERARD
2019-09-30 17:23 ` [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached Anthony PERARD
2019-09-30 18:10 ` Sander Eikelenboom [this message]
2019-10-01 10:35 ` Anthony PERARD
2019-10-10 16:13 ` Sander Eikelenboom
2019-10-14 15:03 ` Chao Gao
2019-10-15 16:59 ` Sander Eikelenboom
2019-10-15 18:46 ` Sander Eikelenboom
2019-10-16 4:55 ` Chao Gao
2019-10-18 16:11 ` Anthony PERARD
2019-10-18 16:43 ` Sander Eikelenboom
2019-10-02 15:45 ` [Xen-devel] [PATCH 0/2] libxl fixes with pci passthrough Ian Jackson
2019-10-02 15:58 ` Jürgen Groß
2019-10-04 15:55 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0590e03b-a455-1aa3-40f3-2ef96827d669@eikelenboom.it \
--to=linux@eikelenboom.it \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).