From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E33CC433B4 for ; Thu, 8 Apr 2021 12:30:12 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48608610C8 for ; Thu, 8 Apr 2021 12:30:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48608610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.107299.205120 (Exim 4.92) (envelope-from ) id 1lUTnK-0005n0-K9; Thu, 08 Apr 2021 12:29:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 107299.205120; Thu, 08 Apr 2021 12:29:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUTnK-0005mt-HE; Thu, 08 Apr 2021 12:29:58 +0000 Received: by outflank-mailman (input) for mailman id 107299; Thu, 08 Apr 2021 12:29:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUTnI-0005mo-VB for xen-devel@lists.xenproject.org; Thu, 08 Apr 2021 12:29:56 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 178b3c63-22d6-4a6a-937e-16091006bdfa; Thu, 08 Apr 2021 12:29:56 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7871DB11B; Thu, 8 Apr 2021 12:29:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 178b3c63-22d6-4a6a-937e-16091006bdfa X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617884995; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YjSH2fpMc5hZ0rfU4D5+PvBOyDoCyUmQcgv8uI1jvBg=; b=LSPbTu4MyD2WH9lSthnXrY4NBkyi7gabPeNh+AJ3SD++dcbdBZ97AMGmA/3UBj28NQ2TMj NAUeCGTaRefF1KkMIfxxxDjSon5dLmpYufQZRYAySAST1b36scTD8c6q6NDkwXMciBAdXD cK/HxRnghw39gPnTI+pl802j8nrzKF8= Subject: Re: [PATCH 02/11] x86/vPMU: avoid effectively open-coding xzalloc_flex_struct() To: Andrew Cooper Cc: George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky , "xen-devel@lists.xenproject.org" References: From: Jan Beulich Message-ID: <0621335d-684c-223b-deec-a2ee028d991d@suse.com> Date: Thu, 8 Apr 2021 14:29:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08.04.2021 14:25, Andrew Cooper wrote: > On 08/04/2021 13:17, Jan Beulich wrote: >> There is a difference in generated code: xzalloc_bytes() forces >> SMP_CACHE_BYTES alignment. I think we not only don't need this here, but >> actually don't want it. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. >> --- a/xen/arch/x86/cpu/vpmu_intel.c >> +++ b/xen/arch/x86/cpu/vpmu_intel.c >> @@ -461,10 +461,10 @@ static int core2_vpmu_alloc_resource(str >> goto out_err; >> } >> >> - core2_vpmu_cxt = xzalloc_bytes(sizeof(*core2_vpmu_cxt) + >> - sizeof(uint64_t) * fixed_pmc_cnt + >> - sizeof(struct xen_pmu_cntr_pair) * >> - arch_pmc_cnt); >> + core2_vpmu_cxt = xzalloc_flex_struct(struct xen_pmu_intel_ctxt, regs, >> + fixed_pmc_cnt + arch_pmc_cnt * >> + (sizeof(struct xen_pmu_cntr_pair) / >> + sizeof(*core2_vpmu_cxt->regs))); >> p = xzalloc(uint64_t); > > However, this is very wtf, and clearly wants reworking.  I'll see if I > can find some time, unless anyone else beats me to it. I thought so too while seeing this, but it's quite a bit more of a rework than I felt I'd like to tackle right away. Jan