From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA3EC4361B for ; Mon, 7 Dec 2020 09:58:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2E4A2310B for ; Mon, 7 Dec 2020 09:58:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2E4A2310B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.46050.81677 (Exim 4.92) (envelope-from ) id 1kmDHi-0001l9-4t; Mon, 07 Dec 2020 09:58:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 46050.81677; Mon, 07 Dec 2020 09:58:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmDHi-0001l2-1p; Mon, 07 Dec 2020 09:58:22 +0000 Received: by outflank-mailman (input) for mailman id 46050; Mon, 07 Dec 2020 09:58:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmDHg-0001kW-TY for xen-devel@lists.xenproject.org; Mon, 07 Dec 2020 09:58:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f36f4ce9-95d2-4831-ac80-bcad4e6e2eac; Mon, 07 Dec 2020 09:58:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 431AFAC90; Mon, 7 Dec 2020 09:58:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f36f4ce9-95d2-4831-ac80-bcad4e6e2eac X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607335099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RzAHNozzVBGVrFrACWfsc9DLFMUyjue6sLOqfcHKseA=; b=i0J+8xD2GwOueg+7yGV5xvlxdXdgEc2+T1qk15KQdhJkT7IrTlv1lMATC84bDJTX4quEum QeZRShy1HSOsDpspxpdhF/6HwjdoR51oeuuy5xBEi5D21vGbO/KM9w7FTeaXYMJFyqz0xx LOSqH8l44VRXvZOJds4cTeA5dTSVwZU= Subject: Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned To: Dario Faggioli Cc: George Dunlap , Andrew Cooper , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org References: <20201201082128.15239-1-jgross@suse.com> <20201201082128.15239-5-jgross@suse.com> From: Jan Beulich Message-ID: <08e50e63-6146-fff2-01b1-d3d212b56092@suse.com> Date: Mon, 7 Dec 2020 10:58:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04.12.2020 16:52, Dario Faggioli wrote: > On Tue, 2020-12-01 at 09:21 +0100, Juergen Gross wrote: >> The cpupool id is an unsigned value in the public interface header, >> so >> there is no reason why it is a signed value in struct cpupool. >> >> Switch it to unsigned int. >> > I think we can add: > > "No functional change intended" > >> Signed-off-by: Juergen Gross >> > IAC: > > Reviewed-by: Dario Faggioli FAOD this applies without any further changes, i.e. not even my suggestion regarding the definition of CPUPOOLID_NONE to XEN_SYSCTL_CPUPOOL_PAR_ANY, or - not said explicitly in the earlier reply - at least the avoidance of open-coding UINT_MAX? Jan