From: Julien Grall <julien.grall@linaro.org>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
"Hao, Xudong" <xudong.hao@intel.com>
Cc: Lars Kurth <lars.kurth@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"Kang, Luwei" <luwei.kang@intel.com>,
"Zhang, PengtaoX" <pengtaox.zhang@intel.com>,
Julien Grall <julien.grall@arm.com>, Quan Xu <quan.xu0@gmail.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>,
Anthony PERARD <anthony.perard@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [BUG] win2008 guest cannot get ip through sriov
Date: Thu, 9 Nov 2017 14:37:22 +0000 [thread overview]
Message-ID: <09902c10-24f9-f054-774e-db89cdf67c7c@linaro.org> (raw)
In-Reply-To: <e9f3c883-ce3a-9673-4b94-7b2f3c553c17@linaro.org>
On 09/11/17 14:36, Julien Grall wrote:
> Hi Roger,
>
> On 09/11/17 09:27, Roger Pau Monné wrote:
>> On Thu, Nov 09, 2017 at 12:22:49AM +0000, Hao, Xudong wrote:
>>>> Qemu-xen didn't have commit a80363, so I report this issue to ask
>>>> for sync up
>>>> with qemu upstream. Last mail I mean I usually used Qemu Xen tree to
>>>> do test,
>>>> and found out this issue.
>>>>
>>>> Before requesting the backport, have you tested whether it fixes
>>>> your issues?
>>>>
>>>
>>> Yes, Luwei (Cced) tested it with pass result.
>>
>> In which case requesting a backport would be in place on the grounds
>> that's a bug fix.
>>
>> The patch in question fixes a bug mostly seen when doing
>> PCI-passthrough of devices that support MSI-X interrupts to Windows
>> guest (and Windows attempts to setup the interrupts using MSI-X). It
>> doesn't manifest on Linux or FreeBSD because these OSes use a
>> different dance to setup MSI-X interrupts, and thus are not affected.
>> It's likely that other OSes with different MSI-X implementations are
>> able to trigger that bug. The result of not having the patch is that
>> interrupts of passed through devices will stay masked, thus
>> preventing the device from working (unless polling mode only is
>> used).
>>
>> Pros:
>> - It fixes a bug.
>> - The patch is not very big or intrusive.
>>
>> Cons:
>> - It hasn't been tested as it's not in qemu-xen.
>> - Only Windows is affected by the bug AFAIK.
>>
>> IMHO, iff the backport is accepted it should be performed ASAP, so
>> that the patch can be properly tested before the release.
>
> Thank you for the detailed explanation :). On a previous e-mail Stefano
> were happy with the backport. So:
>
> Release-acked-by: Julien Grall <julien.grall@linaro.org>
Note that I think we would need to update xen also to point to the
commit with this backport included.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-11-09 14:37 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 9:04 [BUG] win2008 guest cannot get ip through sriov Zhang, PengtaoX
2016-05-27 10:39 ` Wei Liu
2016-05-27 12:16 ` Jan Beulich
2016-05-27 13:34 ` Wei Liu
2016-05-27 14:06 ` Jan Beulich
2016-06-02 7:31 ` Xu, Quan
2016-06-02 9:03 ` Jan Beulich
2016-06-02 10:22 ` Wei Liu
2016-06-02 10:38 ` Jan Beulich
2016-06-02 11:03 ` Wei Liu
2016-06-02 12:08 ` Jan Beulich
2016-06-02 13:05 ` Xu, Quan
2016-06-02 13:30 ` Jan Beulich
2016-06-02 14:02 ` Xu, Quan
2016-06-07 5:52 ` Xu, Quan
2016-06-07 6:07 ` Xu, Quan
2016-06-07 7:43 ` Jan Beulich
2016-06-07 7:49 ` Jan Beulich
2016-06-07 8:03 ` Xu, Quan
2016-06-07 8:08 ` Jan Beulich
2016-06-07 8:19 ` Xu, Quan
2016-06-08 9:12 ` Xu, Quan
2016-06-08 9:25 ` Jan Beulich
2017-10-27 7:27 ` Hao, Xudong
2017-10-27 8:37 ` Jan Beulich
2017-10-27 8:58 ` Hao, Xudong
2017-10-27 10:41 ` Julien Grall
2017-10-27 20:16 ` Stefano Stabellini
2017-11-02 13:49 ` Julien Grall
2017-11-03 1:10 ` Hao, Xudong
2017-11-03 11:23 ` Roger Pau Monné
2017-11-06 1:04 ` Hao, Xudong
2017-11-07 9:33 ` Roger Pau Monné
2017-11-09 0:22 ` Hao, Xudong
2017-11-09 9:27 ` Roger Pau Monné
2017-11-09 14:36 ` Julien Grall
2017-11-09 14:37 ` Julien Grall [this message]
2017-11-27 3:20 ` Hao, Xudong
2017-11-27 10:39 ` Julien Grall
2017-11-06 1:07 ` Hao, Xudong
2017-11-08 12:13 ` Anthony PERARD
2017-11-08 12:17 ` Julien Grall
2017-10-30 1:04 ` Hao, Xudong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09902c10-24f9-f054-774e-db89cdf67c7c@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=julien.grall@arm.com \
--cc=lars.kurth@citrix.com \
--cc=luwei.kang@intel.com \
--cc=pengtaox.zhang@intel.com \
--cc=quan.xu0@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).