From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien@xen.org>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] xen/domain: Introduce domain_teardown()
Date: Tue, 22 Dec 2020 08:50:07 +0100 [thread overview]
Message-ID: <09fd7598-9899-9b4c-68ba-f90b3bc47d6f@suse.com> (raw)
In-Reply-To: <7edf2139-b63e-00c9-7172-524566f942ae@citrix.com>
On 21.12.2020 19:45, Andrew Cooper wrote:
> On 21/12/2020 18:36, Julien Grall wrote:
>>> @@ -553,6 +606,9 @@ struct domain *domain_create(domid_t domid,
>>> if ( init_status & INIT_watchdog )
>>> watchdog_domain_destroy(d);
>>> + /* Must not hit a continuation in this context. */
>>> + ASSERT(domain_teardown(d) == 0);
>> The ASSERT() will become a NOP in production build, so
>> domain_teardown_down() will not be called.
>
> Urgh - its not really a nop, but it's evaluation isn't symmetric between
> debug and release builds. I'll need an extra local variable.
Or use ASSERT_UNREACHABLE(). (I admit I don't really like the
resulting constructs, and would like to propose an alternative,
even if I fear it'll be controversial.)
>> However, I think it would be better if we pass an extra argument to
>> indicated wheter the code is allowed to preempt. This would make the
>> preemption check more obvious in evtchn_destroy() compare to the
>> current d->is_dying != DOMDYING_dead.
>
> We can have a predicate if you'd prefer, but plumbing an extra parameter
> is wasteful, and can only cause confusion if it is out of sync with
> d->is_dying.
I agree here - it wasn't so long ago that event_channel.c gained
a DOMDYING_dead check, and I don't see why we shouldn't extend
this approach to here and elsewhere.
Jan
next prev parent reply other threads:[~2020-12-22 7:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 18:14 [PATCH 0/3] xen/domain: More structured teardown Andrew Cooper
2020-12-21 18:14 ` [PATCH 1/3] xen/domain: Reorder trivial initialisation in early domain_create() Andrew Cooper
2020-12-22 10:10 ` Jan Beulich
2020-12-22 10:24 ` Andrew Cooper
2020-12-22 10:50 ` Jan Beulich
2020-12-21 18:14 ` [PATCH 2/3] xen/domain: Introduce domain_teardown() Andrew Cooper
2020-12-21 18:36 ` Julien Grall
2020-12-21 18:45 ` Andrew Cooper
2020-12-22 7:50 ` Jan Beulich [this message]
2020-12-22 10:25 ` Julien Grall
2020-12-22 10:53 ` Jan Beulich
2020-12-22 11:05 ` Julien Grall
2020-12-22 11:11 ` Andrew Cooper
2020-12-22 10:35 ` Jan Beulich
2020-12-22 11:46 ` Andrew Cooper
2020-12-22 11:55 ` Jan Beulich
2020-12-21 18:14 ` [PATCH 3/3] xen/evtchn: Clean up teardown handling Andrew Cooper
2020-12-22 10:48 ` Jan Beulich
2020-12-22 11:28 ` Andrew Cooper
2020-12-22 11:52 ` Jan Beulich
2020-12-22 13:33 ` Andrew Cooper
2020-12-22 13:45 ` Jan Beulich
2020-12-21 19:36 ` Hypercall fault injection (Was [PATCH 0/3] xen/domain: More structured teardown) Andrew Cooper
2020-12-22 10:00 ` Jan Beulich
2020-12-22 11:14 ` Andrew Cooper
2020-12-22 15:47 ` Tamas K Lengyel
2020-12-22 17:17 ` Andrew Cooper
2020-12-22 18:24 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09fd7598-9899-9b4c-68ba-f90b3bc47d6f@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).