From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83310C433F5 for ; Wed, 27 Oct 2021 09:59:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50CD361052 for ; Wed, 27 Oct 2021 09:59:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50CD361052 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.216854.376616 (Exim 4.92) (envelope-from ) id 1mffiK-0005Mb-NN; Wed, 27 Oct 2021 09:59:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 216854.376616; Wed, 27 Oct 2021 09:59:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mffiK-0005MU-KF; Wed, 27 Oct 2021 09:59:20 +0000 Received: by outflank-mailman (input) for mailman id 216854; Wed, 27 Oct 2021 09:59:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mffiI-0005MO-Fc for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:59:19 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 093f47d1-09a4-433a-a7b4-2b2c755d0fae; Wed, 27 Oct 2021 09:59:15 +0000 (UTC) Received: from [2a01:4c8:1042:994a:f240:791a:356:222b] (helo=[IPv6:::1]) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mffgA-00HYMy-VW; Wed, 27 Oct 2021 09:57:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 093f47d1-09a4-433a-a7b4-2b2c755d0fae DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:References:In-Reply-To:Subject:CC:To:From:Date:Sender :Reply-To:Content-ID:Content-Description; bh=IB3vKlP4on8GCe7l1kqRxw29zumVr5j1/nr3g3ShAqE=; b=TFIclONAtSjKcxHyXMw0hxIXQg i4qFpmRUnP0XhR8jx0r1ZLqVzGWnv9mIVHcPsi9zG9WQ2J/E0svgPJHZ/LvBhs7TAq7J9zJ43i77v LxpF4ceCthZEDDUxkwZeU0LU9nwkCIg7c7VZx7VXJosiC5OXg/yfwCSg/ZRN+kI9OQYOD0QpZo1Li /uafDQmCFr5fdEYZ455y1c71uWucC4UVAeOkl2BanY32VDjOW6CfbndZeTchTqLA3A/QlZV+Ti+j5 P2KEFwiccphpVCEFqctNvOIpWJMxcn4NyiHbNyakPWd6p10E2q7SCSUWB1TZs0ea7MUef/E18ySzd JGx5THPg==; Date: Wed, 27 Oct 2021 10:57:04 +0100 From: David Woodhouse To: Thomas Gleixner , Jason Andryuk , josef@oderland.se CC: boris.ostrovsky@oracle.com, helgaas@kernel.org, jandryuk@gmail.com, jgross@suse.com, linux-pci@vger.kernel.org, maz@kernel.org, xen-devel@lists.xenproject.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_PCI/MSI=3A_Move_non-mask_?= =?US-ASCII?Q?check_back_into_low_level_accessors?= User-Agent: K-9 Mail for Android In-Reply-To: <87cznqg5k8.ffs@tglx> References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se> <20211025012503.33172-1-jandryuk@gmail.com> <87fssmg8k4.ffs@tglx> <87cznqg5k8.ffs@tglx> Message-ID: <0A9FDABA-9067-4811-9B3D-DAFE5589D1A4@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On 27 October 2021 10:50:15 BST, Thomas Gleixner wr= ote: >The recent rework of PCI/MSI[X] masking moved the non-mask checks from th= e >low level accessors into the higher level mask/unmask functions=2E > >This missed the fact that these accessors can be invoked from other place= s >as well=2E The missing checks break XEN-PV which sets pci_msi_ignore_mask= and >also violates the virtual MSIX and the msi_attrib=2Emaskbit protections= =2E Not just PV=2E It's Xen HVM guests too=2E I'll also give it a spin on both Xen and not-Xen=2E Thanks=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E