From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68F9CC6FA82 for ; Tue, 20 Sep 2022 23:24:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.409608.652607 (Exim 4.92) (envelope-from ) id 1oamav-0005r1-2O; Tue, 20 Sep 2022 23:24:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409608.652607; Tue, 20 Sep 2022 23:24:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamau-0005qu-Vw; Tue, 20 Sep 2022 23:24:00 +0000 Received: by outflank-mailman (input) for mailman id 409608; Tue, 20 Sep 2022 23:24:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamau-0005qo-AZ for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 23:24:00 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4df637d3-393b-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 01:23:59 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id y17so9824693ejo.6 for ; Tue, 20 Sep 2022 16:23:59 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-054-006-055.78.54.pool.telefonica.de. [78.54.6.55]) by smtp.gmail.com with ESMTPSA id j22-20020a508a96000000b0044ed7a75c33sm689265edj.6.2022.09.20.16.23.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 16:23:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4df637d3-393b-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=qKZPVG5iME12/xaovZM6A6+qsWvmHnon3GYaJNYHOS8=; b=fCK9HNlTrRewEDKb1ki/vTFY3BFU4vzCnR5/5SporYyj2K3I0iIme7NT7sFxvxSWk3 umbS7mgSQHCv4vemkhsUb7I8ViXwtdzvdECA7Hg1aPJOJHkBgajnUvnzOd15ofRxvKPW 2NmhmYzO4jI0zH5j583BH2fYOyCqRhQagr8KEfGrHxwOvw9vpW0RHacBcO/xfLZqnbG9 JGQYdHCVFxtkFHNb5If1sypH5E1lsaKJVmD0Bts992LCNZLkqOhf1P9RqHOcsUAWXlWu d4YWu7xGj+i6DW0je9gZb13SoS+moDDgWL9JmB1tDOJPynLYKJKZy8VNJloyV8FGfrcV cuNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=qKZPVG5iME12/xaovZM6A6+qsWvmHnon3GYaJNYHOS8=; b=0qEUS3okSv3QwqoyQA/5lKghi34dbS3gMZj81WArZ8W6iWH0h+Ue/1RdUcOZXj0J1Z KTV5ltnm/01lr9IR1r7E2tmRu5pE3VyW2u7OM92pQWcJlMoO1pGkI1pLyAVX2B1cuMSi IL03SzyceUA0F79QLo0eLrN8RzOp4oKwKpjlBySmYRxmLxR1rwrUhgT2tuVQpBZb3AZS UpumV2eh5/8RcqWTb0uDCK7ap4RH3o29J6CUfRqlbT5fDD6LGCf2FSEXfBCSUVruXdzk jgfv1QeGi32Z3oTLkmx37VPbl4tyL+RCUWt4nosD8lUcIeaJOputhAg/E49Nl/mf3j7Z lj9A== X-Gm-Message-State: ACrzQf0/1T8N92CdJSH+T1fNqIVJfQTGai6bFojUQWn4GjojPu+VMI+c mJ4sidNjHm9HWovDXA+MV+4= X-Google-Smtp-Source: AMsMyM5RM/OVc3EykNVPTfjHa4cDBJJ/DnJiA70xAhCb8RUZeIR5sVs3l/o+BP+JEU8fpdRpHUyjcA== X-Received: by 2002:a17:906:eec9:b0:73d:c369:690f with SMTP id wu9-20020a170906eec900b0073dc369690fmr19058158ejb.767.1663716238901; Tue, 20 Sep 2022 16:23:58 -0700 (PDT) Date: Tue, 20 Sep 2022 23:23:52 +0000 From: Bernhard Beschow To: Markus Armbruster , Alistair Francis , Bin Meng , Palmer Dabbelt CC: "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState In-Reply-To: <87edw6xoog.fsf@pond.sub.org> References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> <87edw6xoog.fsf@pond.sub.org> Message-ID: <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 20=2E September 2022 11:36:47 UTC schrieb Markus Armbruster : >Alistair Francis writes: > >> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow = wrote: >>> >>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it = to >>> inherit from TYPE_MACHINE=2E This is an inconsistency which can cause >>> undefined behavior such as memory corruption=2E >>> >>> Change SiFiveEState to inherit from MachineState since it is registere= d >>> as a machine=2E >>> >>> Signed-off-by: Bernhard Beschow >> >> Reviewed-by: Alistair Francis > >To the SiFive maintainers: since this is a bug fix, let's merge it right >away=2E I could repost this particular patch with the three new tags (incl=2E Fixe= s) if desired=2E Best regards, Bernhard >