From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C3AC47247 for ; Tue, 5 May 2020 06:26:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 890702064A for ; Tue, 5 May 2020 06:26:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 890702064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jVr24-0002n0-Is; Tue, 05 May 2020 06:26:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jVr23-0002mv-UC for xen-devel@lists.xenproject.org; Tue, 05 May 2020 06:26:19 +0000 X-Inumbo-ID: 538d687b-8e99-11ea-9d8c-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 538d687b-8e99-11ea-9d8c-12813bfff9fa; Tue, 05 May 2020 06:26:19 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 020FAAB8F; Tue, 5 May 2020 06:26:19 +0000 (UTC) Subject: Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment To: Andrew Cooper , Julien Grall , Stefano Stabellini References: <9d4b738a-4487-6bfc-3076-597d074c7b47@suse.com> <20200422082610.GA28601@Air-de-Roger> From: Jan Beulich Message-ID: <0b43670b-cc0b-0b0b-ef24-4734de35d4b7@suse.com> Date: Tue, 5 May 2020 08:26:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200422082610.GA28601@Air-de-Roger> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Tim Deegan , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 22.04.2020 10:26, Roger Pau Monné wrote: > On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: >> First of all avoid excessive conversions. copy_{from,to}_guest(), for >> example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). >> >> Further >> - do_physdev_op_compat() didn't use the param form for its parameter, >> - {hap,shadow}_track_dirty_vram() wrongly used the param form, >> - compat processor Px logic failed to check compatibility of native and >> compat structures not further converted. >> >> As this eliminates all users of guest_handle_from_param() and as there's >> no real need to allow for conversions in both directions, drop the >> macros as well. >> >> Signed-off-by: Jan Beulich >>[...] >> --- a/xen/drivers/acpi/pmstat.c >> +++ b/xen/drivers/acpi/pmstat.c >> @@ -492,7 +492,7 @@ int do_pm_op(struct xen_sysctl_pm_op *op >> return ret; >> } >> >> -int acpi_set_pdc_bits(u32 acpi_id, XEN_GUEST_HANDLE_PARAM(uint32) pdc) >> +int acpi_set_pdc_bits(u32 acpi_id, XEN_GUEST_HANDLE(uint32) pdc) > > Nit: switch to uint32_t while there? > > Reviewed-by: Roger Pau Monné Unless I hear objections, I'm intending to commit this then in a day or two with the suggested change made and the R-b given. Of course a formally required ack for the Arm side dropping of guest_handle_from_param() would still be nice ... Jan