From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCFEC433DF for ; Tue, 16 Jun 2020 07:57:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 458F7206D7 for ; Tue, 16 Jun 2020 07:57:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 458F7206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jl6T6-0001iB-Vx; Tue, 16 Jun 2020 07:57:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jl6T5-0001hz-T7 for xen-devel@lists.xenproject.org; Tue, 16 Jun 2020 07:57:15 +0000 X-Inumbo-ID: fd4f66a0-afa6-11ea-b893-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fd4f66a0-afa6-11ea-b893-12813bfff9fa; Tue, 16 Jun 2020 07:57:14 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 401FCAC53; Tue, 16 Jun 2020 07:57:17 +0000 (UTC) Subject: Re: [PATCH for-4.13] tools/libxl: Fix memory leak in libxl_cpuid_set() To: Andrew Cooper References: <20200612173227.4103-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <0b7a42e1-23b2-536c-1c08-d2d540d590d0@suse.com> Date: Tue, 16 Jun 2020 09:57:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200612173227.4103-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 12.06.2020 19:32, Andrew Cooper wrote: > xc_cpuid_set() returns allocated memory via cpuid_res, which libxl needs to > free() seeing as it discards the results. > > This is logically a backport of c/s b91825f628 "tools/libxc: Drop > config_transformed parameter from xc_cpuid_set()" but rewritten as one caller > of xc_cpuid_set() does use returned values. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich in case it helps. Jan