From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF163C433E0 for ; Tue, 4 Aug 2020 15:30:58 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF55D2086A for ; Tue, 4 Aug 2020 15:30:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF55D2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2yto-0002op-ME; Tue, 04 Aug 2020 15:30:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ytn-0002ok-BH for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:30:43 +0000 X-Inumbo-ID: e7fafa4a-965e-468e-97bc-fd1747f3410c Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e7fafa4a-965e-468e-97bc-fd1747f3410c; Tue, 04 Aug 2020 15:30:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 86F16B675; Tue, 4 Aug 2020 15:30:56 +0000 (UTC) Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y To: Nick Rosbrook References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> From: Jan Beulich Message-ID: <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> Date: Tue, 4 Aug 2020 17:30:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 17:22, Nick Rosbrook wrote: > On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: >> >> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: >>> While this doesn't address the real problem I've run into (attempting to >>> update r/o source files), not recursing into tools/golang/xenlight/ is >>> enough to fix the build for me for the moment. I don't currently see why >>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found >>> it necessary to invoke this build step unconditionally. >>> >> >> Perhaps an oversight? > > This is intentional, and I think the commit message in 60db5da62ac0 > ("libxl: Generate golang bindings in libxl Makefile") explains the > reasoning well. But, to summarize, CONFIG_GOLANG is only used to > control the bindings actually being compiled (i.e. with `go build`). > However, we always want the code generation script > (tools/golang/xenlight/gengotypes.py) to run if e.g. > tools/libxl/libxl_types.idl is modified. > > I hope this helps. Not really - I'm still not seeing the "why" behind this behavior. I.e. why build _anything_ that's not used further in the build, nor getting installed? Also if (aiui) you effectively object to the change that Wei has given his ack for, would you mind providing an alternative fix for the problem at hand? Jan