From: Jan Beulich <jbeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 1/2] AMD/IOMMU: correct handling when XT's prereq features are unavailable
Date: Fri, 28 Feb 2020 13:45:42 +0100 [thread overview]
Message-ID: <0ee962c8-17f5-6c7c-cb36-158231887670@suse.com> (raw)
In-Reply-To: <20200228123331.GX24458@Air-de-Roger.citrite.net>
On 28.02.2020 13:41, Roger Pau Monné wrote:
> On Fri, Feb 28, 2020 at 01:10:59PM +0100, Jan Beulich wrote:
>> We should neither cause IOMMU initialization as a whole to fail in this
>> case (we should still be able to bring up the system in non-x2APIC or
>> x2APIC physical mode), nor should the remainder of the function be
>> skipped (as the main part of it won't get entered a 2nd time)
>
> I'm not sure I see why it won't get entered a second time. AFAICT
> init_done won't be set if amd_iommu_init fails, and hence will be
> called again with xt == false in iov_detect?
>
>> in such an
>> event. It is merely necessary for the function to indicate to the caller
>> (iov_supports_xt()) that setup failed as far as x2APIC is concerned.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> LGTM, but it needs to go in with 2/2 AFAICT, or else you would report
> interrupt remapping enabled and x2APIC also enabled but won't handle
> correctly a 32 bit destination field.
Well, this is an improvement on its own imo, even if it doesn't
fully fix everything. The primary point here is to make IOMMU
initialization not fail altogether, when the system could be run
in xAPIC mode.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-28 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 12:09 [Xen-devel] [PATCH v2 0/2] AMD/IOMMU: improve x2APIC handling when XT is unavailable Jan Beulich
2020-02-28 12:10 ` [Xen-devel] [PATCH v2 1/2] AMD/IOMMU: correct handling when XT's prereq features are unavailable Jan Beulich
2020-02-28 12:38 ` Andrew Cooper
2020-02-28 12:41 ` Roger Pau Monné
2020-02-28 12:45 ` Jan Beulich [this message]
2020-02-28 13:13 ` Jan Beulich
2020-02-28 14:46 ` Roger Pau Monné
2020-02-28 12:12 ` [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode Jan Beulich
2020-02-28 12:31 ` Roger Pau Monné
2020-02-28 12:39 ` Jan Beulich
2020-02-28 15:21 ` Roger Pau Monné
2020-03-03 16:05 ` Jan Beulich
2020-03-03 16:11 ` Jan Beulich
2020-02-28 14:48 ` Andrew Cooper
2020-02-28 15:04 ` Jan Beulich
2020-03-09 8:58 ` Jan Beulich
2020-03-10 1:10 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ee962c8-17f5-6c7c-cb36-158231887670@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).