From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C99CC433F5 for ; Wed, 15 Dec 2021 09:21:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.247265.426323 (Exim 4.92) (envelope-from ) id 1mxQSz-00032S-Go; Wed, 15 Dec 2021 09:20:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 247265.426323; Wed, 15 Dec 2021 09:20:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxQSz-00032L-Dr; Wed, 15 Dec 2021 09:20:53 +0000 Received: by outflank-mailman (input) for mailman id 247265; Wed, 15 Dec 2021 09:20:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxQSx-00032C-Ux for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 09:20:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxQSt-00085a-PN; Wed, 15 Dec 2021 09:20:47 +0000 Received: from [54.239.6.190] (helo=[10.85.97.145]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mxQSt-0002o7-Ig; Wed, 15 Dec 2021 09:20:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=OCQYv43R9XULZPs9AF1DXysbDDo+UclFveHYvBtLyxA=; b=mQgzMWgqd7YuUXGq3RlD/2SYwm aNnIc8OfI83iDq79CGekBtJ0yez+j1Yg6pnZKD7Sap9su2Bn4idtCqfJzCqV7Si4L0+ZRDEit9q1T C1fNn2Yo4I3FslAcO8Ycy1xZux4suPWvQm7Ov3HF1u1fOeCI7DqLOyU9FDMpZD8T2BKk=; Message-ID: <10dff775-9890-0ecb-6b71-f61893051ad2@xen.org> Date: Wed, 15 Dec 2021 09:20:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [XEN PATCH v8 14/47] build: rename __LINKER__ to LINKER_SCRIPT To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Bertrand Marquis , xen-devel@lists.xenproject.org, Anthony PERARD References: <20211125134006.1076646-1-anthony.perard@citrix.com> <20211125134006.1076646-15-anthony.perard@citrix.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 15/12/2021 07:49, Jan Beulich wrote: > On 14.12.2021 18:05, Julien Grall wrote: >> On 25/11/2021 13:39, Anthony PERARD wrote: >>> For two reasons: this macro is used to generate a "linker script" and >>> is not by the linker, and name starting with an underscore '_' are >>> supposed to be reserved, so better avoid them when not needed. >> >> If that's the case, then shouldn't we also rename __ASSEMBLY__? > > I'd rather not - unlike __LINKER__ (afaict at least) __ASSEMBLY__ I can't remember where I took __LINKER__ from. > is a commonly used identifier (which we've actually inherited from > Linux) Fair enough. Cheers, -- Julien Grall