From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v3 7/8] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn Date: Fri, 24 Jun 2016 15:03:31 +0100 Message-ID: <11bd382d-9a7b-868f-d809-dd18da57f118@citrix.com> References: <1466515243-27264-1-git-send-email-julien.grall@arm.com> <1466515243-27264-8-git-send-email-julien.grall@arm.com> <576D3C6E.70800@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <576D3C6E.70800@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall , Stefano Stabellini Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gMjQvMDYvMTYgMTQ6NTgsIEp1bGllbiBHcmFsbCB3cm90ZToKPiBIaSBTdGVmYW5vLAo+Cj4g T24gMjMvMDYvMTYgMTU6MTQsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToKPj4gT24gVHVlLCAy MSBKdW4gMjAxNiwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+Pj4gVGhlIHByb3RvdHlwZSBhbmQgdGhl IGRlY2xhcmF0aW9uIG9mIHAybV9sb29rdXAgZGlzYWdyZWUgb24gaG93IHRoZQo+Pj4gZnVuY3Rp b24gc2hvdWxkIGJlIHVzZWQuIE9uZSBleHBlY3QgYSBmcmFtZSBudW1iZXIgd2hpbHN0IHRoZSBv dGhlcgo+Pj4gYW4gYWRkcmVzcy4KPj4+Cj4+PiBUaGFua2Z1bGx5LCBldmVyeW9uZSBpcyB1c2lu ZyB3aXRoIGFuIGFkZHJlc3MgdG9kYXkuIEhvd2V2ZXIsIG1vc3Qgb2YKPj4+IHRoZSBjYWxsZXJz IGhhdmUgdG8gY29udmVydCBhIGd1ZXN0IGZyYW1lIHRvIGFuIGFkZHJlc3MuIE1vZGlmeQo+Pj4g dGhlIGludGVyZmFjZSB0byB0YWtlIGEgZ3Vlc3QgcGh5c2ljYWwgZnJhbWUgaW4gcGFyYW1ldGVy IGFuZCByZXR1cm4KPj4+IGEgbWFjaGluZSBmcmFtZS4KPj4+Cj4+PiBXaGlsc3QgbW9kaWZ5aW5n IHRoZSBpbnRlcmZhY2UsIHVzZSB0eXBlc2FmZSBnZm4gYW5kIG1mbiBmb3IgY2xhcml0eQo+Pj4g YW5kIGNhdGNoaW5nIHBvc3NpYmxlIG1pc3VzYWdlLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEp1 bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+Cj4+PiAtLS0KPj4+ICAgeGVuL2FyY2gv YXJtL3AybS5jICAgICAgICB8IDM3ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0KPj4+ICAgeGVuL2FyY2gvYXJtL3RyYXBzLmMgICAgICB8IDIxICsrKysrKysrKysrLS0tLS0t LS0tLQo+Pj4gICB4ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oIHwgIDcgKysrLS0tLQo+Pj4gICAz IGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+Pj4KPj4+ IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcDJtLmMgYi94ZW4vYXJjaC9hcm0vcDJtLmMKPj4+ IGluZGV4IDQ3Y2IzODMuLmYzMzMwZGQgMTAwNjQ0Cj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vcDJt LmMKPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9wMm0uYwo+Pj4gQEAgLTE0MCwxNCArMTQwLDE1IEBA IHZvaWQgZmx1c2hfdGxiX2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkKQo+Pj4gICB9Cj4+Pgo+Pj4g ICAvKgo+Pj4gLSAqIExvb2t1cCB0aGUgTUZOIGNvcnJlc3BvbmRpbmcgdG8gYSBkb21haW4ncyBQ Rk4uCj4+PiArICogTG9va3VwIHRoZSBNRk4gY29ycmVzcG9uZGluZyB0byBhIGRvbWFpbidzIEdG Ti4KPj4+ICAgICoKPj4+ICAgICogVGhlcmUgYXJlIG5vIHByb2Nlc3NvciBmdW5jdGlvbnMgdG8g ZG8gYSBzdGFnZSAyIG9ubHkgbG9va3VwCj4+PiB0aGVyZWZvcmUgd2UKPj4+ICAgICogZG8gYSBh IHNvZnR3YXJlIHdhbGsuCj4+PiAgICAqLwo+Pj4gLXN0YXRpYyBwYWRkcl90IF9fcDJtX2xvb2t1 cChzdHJ1Y3QgZG9tYWluICpkLCBwYWRkcl90IHBhZGRyLAo+Pj4gcDJtX3R5cGVfdCAqdCkKPj4+ ICtzdGF0aWMgbWZuX3QgX19wMm1fbG9va3VwKHN0cnVjdCBkb21haW4gKmQsIGdmbl90IGdmbiwg cDJtX3R5cGVfdCAqdCkKPj4+ICAgewo+Pj4gICAgICAgc3RydWN0IHAybV9kb21haW4gKnAybSA9 ICZkLT5hcmNoLnAybTsKPj4+ICsgICAgY29uc3QgcGFkZHJfdCBwYWRkciA9IHBmbl90b19wYWRk cihnZm5feChnZm4pKTsKPj4+ICAgICAgIGNvbnN0IHVuc2lnbmVkIGludCBvZmZzZXRzWzRdID0g ewo+Pj4gICAgICAgICAgIHplcm9ldGhfdGFibGVfb2Zmc2V0KHBhZGRyKSwKPj4+ICAgICAgICAg ICBmaXJzdF90YWJsZV9vZmZzZXQocGFkZHIpLAo+Pj4gQEAgLTE1OCw3ICsxNTksNyBAQCBzdGF0 aWMgcGFkZHJfdCBfX3AybV9sb29rdXAoc3RydWN0IGRvbWFpbiAqZCwKPj4+IHBhZGRyX3QgcGFk ZHIsIHAybV90eXBlX3QgKnQpCj4+PiAgICAgICAgICAgWkVST0VUSF9NQVNLLCBGSVJTVF9NQVNL LCBTRUNPTkRfTUFTSywgVEhJUkRfTUFTSwo+Pj4gICAgICAgfTsKPj4+ICAgICAgIGxwYWVfdCBw dGUsICptYXA7Cj4+PiAtICAgIHBhZGRyX3QgbWFkZHIgPSBJTlZBTElEX1BBRERSOwo+Pj4gKyAg ICBtZm5fdCBtZm4gPSBfbWZuKElOVkFMSURfTUZOKTsKPj4KPj4gSXQgbWlnaHQgYmUgd29ydGgg ZGVmaW5pbmcgSU5WQUxJRF9NRk5fVCBhbmQganVzdCBhc3NpZ24gdGhhdCB0byBtZm4uCj4KPiBH b29kIGlkZWEuIEl0IHdpbGwgYmUgdXNlZnVsIGluIG90aGVyIHBsYWNlcyB0b28uCj4KPj4KPj4+ ICAgICAgIHBhZGRyX3QgbWFzayA9IDA7Cj4+PiAgICAgICBwMm1fdHlwZV90IF90Owo+Pj4gICAg ICAgdW5zaWduZWQgaW50IGxldmVsLCByb290X3RhYmxlOwo+Cj4KPiBbLi4uXQo+Cj4+PiBAQCAt MTU2MSwxMSArMTU2NSwxMCBAQCBwMm1fbWVtX2FjY2Vzc19jaGVja19hbmRfZ2V0X3BhZ2UodmFk ZHJfdAo+Pj4gZ3ZhLCB1bnNpZ25lZCBsb25nIGZsYWcpCj4+PiAgICAgICAgKiBXZSBoYWQgYSBt ZW1fYWNjZXNzIHBlcm1pc3Npb24gbGltaXRpbmcgdGhlIGFjY2VzcywgYnV0IHRoZQo+Pj4gcGFn ZSB0eXBlCj4+PiAgICAgICAgKiBjb3VsZCBhbHNvIGJlIGxpbWl0aW5nLCBzbyB3ZSBuZWVkIHRv IGNoZWNrIHRoYXQgYXMgd2VsbC4KPj4+ICAgICAgICAqLwo+Pj4gLSAgICBtYWRkciA9IF9fcDJt X2xvb2t1cChjdXJyZW50LT5kb21haW4sIGlwYSwgJnQpOwo+Pj4gLSAgICBpZiAoIG1hZGRyID09 IElOVkFMSURfUEFERFIgKQo+Pj4gKyAgICBtZm4gPSBtZm5feChfX3AybV9sb29rdXAoY3VycmVu dC0+ZG9tYWluLCBnZm4sICZ0KSk7Cj4+PiArICAgIGlmICggbWZuID09IElOVkFMSURfTUZOICkK Pj4KPj4gVGhlIGNvbnZlcnNpb24gd291bGQgZ28gYXdheSBpZiB3ZSBoYWQgYW4gSU5WQUxJRF9N Rk4gd2hpY2ggaXMgbWZuX3QKCkJlIGNhcmVmdWwuCgpJTlZBTElEX01GTl9UIGlzIGZpbmUgZm9y IGFzc2lnbm1lbnQsIGJ1dCB5b3UgY2FuJ3QgZG8gcGxhaW4gZXF1YWxpdHkKdGVzdHMgb2Ygb3Bh cXVlIHN0cnVjdHVyZXMuCgptZm5fdCBtID0gX21mbigwKTsKbWZuX3QgaW52YWwgPSBJTlZBTElE X01GTl9UOyAvLyBPawptZm5fZXF1YWwobSwgSU5WQUxJRF9NRk5fVCk7IC8vIE9rCm1mbl9lcXVh bChtLCBpbnZhbCk7IC8vIE9rCm0gPT0gaW52YWw7IC8vIENvbXBpbGF0aW9uIGVycm9yCgpUaGlz IHdhcyB0aGUgcmVhc29uIHRoYXQgSSBkaWRuJ3QgcHJldmlvdXNseSBpbnRyb2R1Y2UgSU5WQUxJ RF9NRk5fVCwKYWx0aG91Z2ggd2l0aCBtZm5fZXF1YWwoKSwgcGVyaGFwcyB0aGUgdGltZSBoYXMg Y29tZS4KCn5BbmRyZXcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==