From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [libvirt bisection] complete build-armhf-libvirt
Date: Fri, 17 Apr 2015 10:54:26 +0100
Message-ID: <1429264466.25195.237.camel@citrix.com>
References: <E1YircT-0005yo-T2@osstest.test-lab.xenproject.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <E1YircT-0005yo-T2@osstest.test-lab.xenproject.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: osstest service user <osstest@xenbits.xen.org>
Cc: keir@xen.org, xen-devel@lists.xensource.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-04-16 at 21:46 +0000, osstest service user wrote:
> branch xen-unstable
> xen branch xen-unstable
> job build-armhf-libvirt
> test libvirt-build
> 
> Tree: libvirt git://libvirt.org/libvirt.git
> Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git
> Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
> Tree: xen git://xenbits.xen.org/xen.git
> 
> *** Found and reproduced problem changeset ***
> 
>   Bug is in tree:  libvirt git://libvirt.org/libvirt.git
>   Bug introduced:  1eccac1d2da7bbe97e1df25fd0ddac6e71b0794a
>   Bug not present: 88dc7e0c2fba1894ec36502aecc229129c8d3111
> 
> 
>   commit 1eccac1d2da7bbe97e1df25fd0ddac6e71b0794a
>   Author: Peter Krempa <pkrempa@redhat.com>
>   Date:   Tue Mar 31 17:29:35 2015 +0200
>   
>       qemu: domain: Add helper to check block job support

This was bisecting the failure in
http://logs.test-lab.xenproject.org/osstest/logs/50417/build-armhf-libvirt/5.ts-libvirt-build.log which was:
qemu/qemu_driver.c: In function 'qemuDomainAddCgroupForThread':
qemu/qemu_driver.c:4641:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
qemu/qemu_driver.c: In function 'qemuDomainHotplugAddPin':
qemu/qemu_driver.c:4674:29: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
qemu/qemu_driver.c: In function 'qemuDomainHotplugPinThread':
qemu/qemu_driver.c:4702:32: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
qemu/qemu_driver.c: In function 'qemuDomainDelCgroupForThread':
qemu/qemu_driver.c:4733:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]

I believe this to have been fixed in mainline.

However, I don't believe the quoted commit has anything to do with the
failure, I suspect there were two overlapping build errors and indeed
the first repro case on the bad commit was
http://logs.test-lab.xenproject.org/osstest/logs/50460/build-armhf-libvirt/5.ts-libvirt-build.log:

qemu/qemu_domain.c: In function 'qemuDomainSupportsBlockJobs':
qemu/qemu_domain.c:3067:11: error: declaration of 'sync' shadows a global declaration [-Werror=shadow]
cc1: all warnings being treated as errors

i.e. another shadow issue. I'll reply to the thread I started about the
other issue.

Ian.