Re: [RFC PATCH v3 16/18] xen/arm: ITS: Handle LPI interrupts

From: Ian Campbell <ian.campbell@citrix.com>
To: vijay.kilari@gmail.com
Cc: stefano.stabellini@eu.citrix.com,
	Prasun.Kapoor@caviumnetworks.com,
	Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
	tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com,
	stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com
Subject: Re: [RFC PATCH v3 16/18] xen/arm: ITS: Handle LPI interrupts
Date: Mon, 29 Jun 2015 14:03:06 +0100	[thread overview]
Message-ID: <1435582986.32500.321.camel@citrix.com> (raw)
In-Reply-To: <1434974517-12136-17-git-send-email-vijay.kilari@gmail.com>

On Mon, 2015-06-22 at 17:31 +0530, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> 
> Handle and route LPI interrupts
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> ---
>  xen/arch/arm/gic.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index 091f7e5..802f82f 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -665,6 +665,11 @@ void gic_interrupt(struct cpu_user_regs *regs, int is_fiq)
>      do  {
>          /* Reading IRQ will ACK it */
>          irq = gic_hw_ops->read_irq();
> +        if ( is_lpi(irq) ) {
> +            /* TODO: Enable irqs */

What was the problem with just doing that?

> +            do_IRQ(regs, irq, is_fiq);
> +            continue;

Either this should be folded with the SPI/PPI handling case below or it
should be part of the same if/if else/else chain as the other cases.
Ideally the former (i.e. fix the interrupt enabling problem).

> +        }
>  
>          if ( likely(irq >= 16 && irq < 1020) )
>          {