From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: [PATCH 0/6] Use system blktap Date: Mon, 6 Jul 2015 11:51:37 +0100 Message-ID: <1436179903-449-1-git-send-email-george.dunlap@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Wei Liu , Felipe Franciosi , Ian Campbell , George Dunlap , Jonathan Ludlam , Dave Scott , Ian Jackson , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org Switch to using a blktap provided by the system, rather than building it in-tree. Do this by adding a block-tap script which calls the tap-ctl binary, rather than linking against a library. This requires the use of an externally-built tap-ctl binary, which an be built from the master branch of the XenServer blktap tree at https://github.com/xapi-project/blktap.git The first two patches and the final patch are general libxl disk handling improvements which can be applied independently of the core. The third patch (tools: Add a block-tap script for setting up tapdisks via tap-ctl) can also be checked in independently from the fourth and fifth, as it allows someone to disable blktap support in configure but still use externally-built tap-ctl binaries (albeit with a different disk string). The fifth patch is a straight rm -rf of toosl/blktap2. Rather than spam everyone's mailboxes I've clipped the message here, and provided a tree which can be pulled from: git://xenbits.xen.org/people/gdunlap/xen.git out/blktap-system/v1 This series also exposes blktap to a bug that prevents HVM guests from using disks created with block scripts. This should be a blocker for the 4.6 release, so I think we should consider checking this series in as is, assuming that bug will be addressed before the release. George Dunlap (6): libxl: Make local_initiate_attach more rational libxl: Remove linux udev rules tools: Add a block-tap script for setting up tapdisks via tap-ctl libxl: Use the block-tap script for LIBXL_DISK_BACKEND_TAP tools: Remove in-tree blktap2 libxl: Add more logging to hotplug script path tools/Makefile | 1 - [tools/blktap2/* removal trimmed] tools/config.h.in | 3 - tools/configure | 29 +- tools/configure.ac | 13 +- tools/examples/README | 1 - tools/hotplug/Linux/Makefile | 15 +- tools/hotplug/Linux/block-tap | 123 + tools/hotplug/Linux/xen-backend.rules.in | 13 - tools/hotplug/Linux/xen-hotplug-common.sh.in | 7 - tools/libxl/Makefile | 5 - tools/libxl/libxl.c | 139 +- tools/libxl/libxl_blktap2.c | 93 - tools/libxl/libxl_create.c | 27 - tools/libxl/libxl_device.c | 34 +- tools/libxl/libxl_dm.c | 5 +- tools/libxl/libxl_internal.c | 19 - tools/libxl/libxl_internal.h | 27 - tools/libxl/libxl_linux.c | 12 +- tools/libxl/libxl_netbsd.c | 7 - tools/libxl/libxl_noblktap2.c | 42 - 146 files changed, 194 insertions(+), 40550 deletions(-) [delete mode 100644 tools/blktap2/* trimmed] -- CC: Ian Campbell CC: Ian Jackson CC: Wei Liu CC: Roger Pau Monne CC: Felipe Franciosi CC: Dave Scott CC: Jonathan Ludlam 1.9.1