From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 14/17] xen/arm: ITS: Add domain specific
 ITS initialization
Date: Fri, 10 Jul 2015 16:41:04 +0100
Message-ID: <1436542864.10074.102.camel@citrix.com>
References: <1436514172-3263-1-git-send-email-vijay.kilari@gmail.com>
	<1436514172-3263-15-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436514172-3263-15-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com
Cc: stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-07-10 at 13:12 +0530, vijay.kilari@gmail.com wrote:
> +void vgic_its_init(void)
> +{
> +    if ( gic_lpi_supported() )
> +        its_lpi_init(gic_nr_id_bits());

Ah, here is some code which tries to only enable this stuff when it is
needed.

I think for the time being this also needs to be gated on dom0, which in
practice means is_hardware_domain(d).

When PCI passthrough lands then this will be changed to gate on
is_hardware_domain(d) || some_option instead.

> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 4e14439..79dbfc4 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -1217,6 +1217,9 @@ static int vgic_v3_domain_init(struct domain *d)
>  
>      d->arch.vgic.ctlr = VGICD_CTLR_DEFAULT;
>  
> +    if ( gic_lpi_supported() )
> +        vits_domain_init(d);


and here as well. I suspect there will be other places too.

Ian.