From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH 5/9] libxl: avoid leaking string in cpupool_info Date: Fri, 10 Jul 2015 19:00:53 +0100 Message-ID: <1436551257-28887-6-git-send-email-wei.liu2@citrix.com> References: <1436551257-28887-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZDcbh-0002FX-Hp for xen-devel@lists.xenproject.org; Fri, 10 Jul 2015 18:01:05 +0000 In-Reply-To: <1436551257-28887-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Andrew Cooper , Ian Jackson , Ian Campbell , Wei Liu List-Id: xen-devel@lists.xenproject.org Signed-off-by: Wei Liu --- tools/libxl/libxl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 38aff8d..4151dcb 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -740,8 +740,10 @@ static int cpupool_info(libxl__gc *gc, info->sched = xcinfo->sched_id; info->n_dom = xcinfo->n_dom; rc = libxl_cpu_bitmap_alloc(CTX, &info->cpumap, 0); - if (rc) + if (rc) { + free(info->pool_name); goto out; + } memcpy(info->cpumap.map, xcinfo->cpumap, info->cpumap.size); -- 1.9.1