From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH OSSTEST v2 09/13] ts-debian-hvm-install: stub out libvirt + ovmf / rombios Date: Sun, 12 Jul 2015 17:20:32 +0100 Message-ID: <1436718036-7985-10-git-send-email-wei.liu2@citrix.com> References: <1436718036-7985-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZEJze-0002VZ-Cj for xen-devel@lists.xenproject.org; Sun, 12 Jul 2015 16:20:42 +0000 In-Reply-To: <1436718036-7985-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: ian.jackson@eu.citrix.com, Wei Liu , ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Libvirt's configuration converter doesn't know how to deal with BIOS selection. The end result is it always use the default one (seabios). Stub out ovmf and rombios to avoid false positive results. This restriction will be removed once libvirt's converter knows how to deal with BIOS selection. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson --- ts-debian-hvm-install | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install index f05b1a7..bd16506 100755 --- a/ts-debian-hvm-install +++ b/ts-debian-hvm-install @@ -28,6 +28,13 @@ if (@ARGV && $ARGV[0] =~ m/^--stage(\d+)$/) { $stage=$1; shift @ARGV; } defined($r{bios}) or die "Need to define which bios to use"; +# Libvirt doesn't know anything about bios. It will always use the +# default one (seabios). Stub out rombios and ovmf to avoid false +# positive results. +if ($r{bios} =~ m/ovmf|rombios/ && $r{toolstack} eq 'libvirt') { + die "libvirt + $r{bios} is not supported yet."; +} + our ($whhost,$gn) = @ARGV; $whhost ||= 'host'; $gn ||= 'debianhvm'; -- 1.9.1