From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/9] libxl: fix libxl__abs_path
Date: Tue, 14 Jul 2015 08:23:15 +0100 [thread overview]
Message-ID: <1436858595.7019.118.camel@citrix.com> (raw)
In-Reply-To: <21923.61840.920833.811619@mariner.uk.xensource.com>
On Mon, 2015-07-13 at 18:12 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 1/9] libxl: fix libxl__abs_path"):
> > I rather dislike subjects of the form "fix $function", since it gives
> > very little clue to someone reading the shortlog what is going on.
>
> Yes.
>
> > In this case I think "libxl: make libxl__abs_path correctly handle a
> > NULL argument" would be an accurate description.
>
> But: it is quite surprising that libxl__abs_path can be legally passed
> a NULL for any of its parameters.
True.
>
> There are no call sites in libxl which can pass a NULL.
>
> I think that if we are to retain this feature, it ought to be
> documented, at least.
>
> Maybe
>
> _hidden char *libxl__abs_path(libxl__gc *gc,
> const char *s /* NULL OK */,
> const char *path);
Or add an assert if we don't wish to support this?
next prev parent reply other threads:[~2015-07-14 7:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 18:00 [PATCH 0/9] xl/libxl: fix issues discovered by Coverity scan Wei Liu
2015-07-10 18:00 ` [PATCH 1/9] libxl: fix libxl__abs_path Wei Liu
2015-07-13 9:57 ` Ian Campbell
2015-07-13 10:00 ` Wei Liu
2015-07-13 17:12 ` Ian Jackson
2015-07-14 7:23 ` Ian Campbell [this message]
2015-07-14 10:23 ` Ian Jackson
2015-07-14 13:32 ` Ian Campbell
2015-07-14 13:58 ` Ian Jackson
2015-07-14 14:10 ` Ian Campbell
2015-07-14 15:50 ` Wei Liu
2015-07-10 18:00 ` [PATCH 2/9] libxl: turn two malloc's to libxl__malloc Wei Liu
2015-07-13 10:00 ` Ian Campbell
2015-07-13 15:29 ` Wei Liu
2015-07-10 18:00 ` [PATCH 3/9] libxl: json string object can be NULL Wei Liu
2015-07-13 10:02 ` Ian Campbell
2015-07-13 17:16 ` Ian Jackson
2015-07-10 18:00 ` [PATCH 4/9] libxl: dispose dominfo to avoid leaking resource Wei Liu
2015-07-13 10:05 ` Ian Campbell
2015-07-13 17:18 ` Ian Jackson
2015-07-10 18:00 ` [PATCH 5/9] libxl: avoid leaking string in cpupool_info Wei Liu
2015-07-13 10:07 ` Ian Campbell
2015-07-13 16:10 ` Wei Liu
2015-07-13 16:23 ` Ian Campbell
2015-07-13 16:24 ` Wei Liu
2015-07-10 18:00 ` [PATCH 6/9] libxl: localtime(3) can return NULL Wei Liu
2015-07-13 10:09 ` Ian Campbell
2015-07-10 18:00 ` [PATCH 7/9] libxl: qmp_init_handler " Wei Liu
2015-07-13 10:10 ` Ian Campbell
2015-07-10 18:00 ` [PATCH 8/9] xl: fix main_cpupoolcreate Wei Liu
2015-07-13 10:11 ` Ian Campbell
2015-07-10 18:00 ` [PATCH 9/9] xl: fix main_config_update Wei Liu
2015-07-13 10:12 ` Ian Campbell
2015-07-10 18:21 ` [PATCH 0/9] xl/libxl: fix issues discovered by Coverity scan Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436858595.7019.118.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).