From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/9] libxl: fix libxl__abs_path
Date: Tue, 14 Jul 2015 15:10:41 +0100
Message-ID: <1436883041.25044.79.camel@citrix.com>
References: <1436551257-28887-1-git-send-email-wei.liu2@citrix.com>
	<1436551257-28887-2-git-send-email-wei.liu2@citrix.com>
	<1436781452.7019.61.camel@citrix.com>
	<21923.61840.920833.811619@mariner.uk.xensource.com>
	<1436858595.7019.118.camel@citrix.com>
	<21924.58143.42391.308384@mariner.uk.xensource.com>
	<1436880745.25044.64.camel@citrix.com>
	<21925.5488.720064.657000@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=630a0ae6d=Ian.Campbell@citrix.com>)
	id 1ZF0vP-0006Ia-GT
	for xen-devel@lists.xenproject.org; Tue, 14 Jul 2015 14:11:11 +0000
In-Reply-To: <21925.5488.720064.657000@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-07-14 at 14:58 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 1/9] libxl: fix libxl__abs_path"):
> > On Tue, 2015-07-14 at 11:23 +0100, Ian Jackson wrote:
> > > If we don't want to support it we can just remove the check and let it
> > > crash.
> > 
> > An assert at least gets us a slightly improved message when it happens.
> 
> If that logic applies here it applies to almost every function in
> libxl.  I don't think this is a sensible approach.

OK.