From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH v3 01/10] libxl: don't check s!=NULL in libxl__abs_path Date: Tue, 14 Jul 2015 17:41:04 +0100 Message-ID: <1436892073-14186-2-git-send-email-wei.liu2@citrix.com> References: <1436892073-14186-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZF3Gh-0002Rj-IC for xen-devel@lists.xenproject.org; Tue, 14 Jul 2015 16:41:19 +0000 In-Reply-To: <1436892073-14186-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Wei Liu , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org That argument should not be NULL. Let subsequent dereferencing crashes the process. Signed-off-by: Wei Liu --- tools/libxl/libxl_internal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c index 42d548e..24a0901 100644 --- a/tools/libxl/libxl_internal.c +++ b/tools/libxl/libxl_internal.c @@ -233,8 +233,7 @@ void libxl__log(libxl_ctx *ctx, xentoollog_level msglevel, int errnoval, char *libxl__abs_path(libxl__gc *gc, const char *s, const char *path) { - if (!s || s[0] == '/') - return libxl__strdup(gc, s); + if (s[0] == '/') return libxl__strdup(gc, s); return libxl__sprintf(gc, "%s/%s", path, s); } -- 1.9.1